901068 - Twitter share button needs updated autofill text

Status: RESOLVED FIXED

(Webmaker Graveyard :: Popcorn Maker, defect)

Description

[Jacob [:Jacob]]

Right now the tweet button under the "share" tab in Popcorn Maker autofills the following text:

Check out the #PopcornMaker page I just made:  https://jake.makes.org/popcorn/1ac6 via @popcornjs

There are two things wrong with this

1) We don't follow the hashtag #popcornmaker and it's a bit long
2) @popcornjs is not @webmaker

so let's change it to the following:

Check out the #Webmaker page I just made:  https://jake.makes.org/popcorn/1ac6 via @Webmaker

Comment 1

[Brett Gaylor [:brett]]

+111111.  Been meaning to file that for a while!  Matt, how'd you like to take this one?

Comment 2

[Matthew Schranz [:mjschranz]]

Attachment: https://github.com/mozilla/popcorn.webmaker.org/pull/151

Cade for a code review.

Cassie, can you let me know if the text there is good?

Comment 3

[Chris DeCairos (:cade)]

Comment on attachment 785187 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/151

R+

Will this conflict with the localization work being done?

Comment 4

[Cassie McDaniel [:cassiemc]]

(In reply to Matthew Schranz [:mjschranz] from comment #2)
> Created attachment 785187 [details] [review]
> https://github.com/mozilla/popcorn.webmaker.org/pull/151
> 
> Cade for a code review.
> 
> Cassie, can you let me know if the text there is good?

Sounds good to me!! Only thing I noticed in Jacob's copy was that there were two spaces in front of the link instead of one.

Comment 5

[Matthew Schranz [:mjschranz]]

(In reply to Chris DeCairos (:cade) from comment #3)
> Comment on attachment 785187 [details] [review]
> https://github.com/mozilla/popcorn.webmaker.org/pull/151
> 
> R+
> 
> Will this conflict with the localization work being done?

Yes, this is probably somewhere we will want to do some localization as well.

Comment 6

[[github robot]]

Commit pushed to master at https://github.com/mozilla/popcorn.webmaker.org

https://github.com/mozilla/popcorn.webmaker.org/commit/793625cdc62a75b626573d41052a6f7eb6711338
Fix Bug 901068 - Update text for twitter share button