Closed
Bug 901147
Opened 11 years ago
Closed 11 years ago
Defect - Js error "Elements.contextappbar.hide is not a function" while running tests
Categories
(Firefox for Metro Graveyard :: App Bar, defect, P2)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 25
People
(Reporter: rsilveira, Assigned: rsilveira)
References
Details
(Whiteboard: feature=defect c=testing u=developer p=1)
Attachments
(1 file)
2.41 KB,
patch
|
mbrubeck
:
review+
|
Details | Diff | Splinter Review |
contextappbar.hide does not exist - it should have been dismiss. But it was being called when clearContextualActions[1] was called, which in turn was called when MozAppbarDismissing happens[2]. We don't need to dismiss after a dismiss, so removing the call. p=1 [1] https://mxr.mozilla.org/mozilla-central/source/browser/metro/base/content/appbar.js?rev=f4bb9ef3bf63#231 [2] https://mxr.mozilla.org/mozilla-central/source/browser/metro/base/content/appbar.js?rev=f4bb9ef3bf63#42
Attachment #785274 -
Flags: review?(mbrubeck)
Updated•11 years ago
|
Attachment #785274 -
Flags: review?(mbrubeck) → review+
Assignee | ||
Comment 1•11 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/f6cc0bc72745
Comment 2•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/f6cc0bc72745
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 25
Comment 3•11 years ago
|
||
Temporarily reopening to add to IT#12.
Blocks: metrov1it12
Status: RESOLVED → REOPENED
QA Contact: jbecerra
Resolution: FIXED → ---
Whiteboard: feature=defect c=testing u=developer p=1
Updated•11 years ago
|
Summary: Js error "Elements.contextappbar.hide is not a function" while running tests → Defect - Js error "Elements.contextappbar.hide is not a function" while running tests
Updated•11 years ago
|
Priority: -- → P2
Updated•11 years ago
|
Status: REOPENED → RESOLVED
Closed: 11 years ago → 11 years ago
Resolution: --- → FIXED
Updated•10 years ago
|
OS: Windows 8 Metro → Windows 8.1
You need to log in
before you can comment on or make changes to this bug.
Description
•