901408 - Page not displayed after switching tabs

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Nick Thomas [:nthomas] (UTC+12)]

STR:
1, open a webpage (eg http://www.nzherald.co.nz)
2, open a couple of links in new tabs
3, switch between the tabs

The first page is still displayed properly on switch, but the two others are displayed as a blank white page. Reloading a blank page gets you the first page, rather than what you had opened.

This broke in the 20130803 nightly build on m-c, bisected to inbound:
last good: f85f06761d52
http://ftp.mozilla.org/pub/mozilla.org/mobile/tinderbox-builds/mozilla-inbound-android/1375396141/fennec-25.0a1.en-US.android-arm.apk

first bad: 82c3a4ad5d69
http://ftp.mozilla.org/pub/mozilla.org/mobile/tinderbox-builds/mozilla-inbound-android/1375397214/fennec-25.0a1.en-US.android-arm.apk

So fingering bug 895655.

Comment 1

[microrffr]

E/GeckoConsole(20180): [JavaScript Error: "ReferenceError: resolveGeckoUri is not defined" {file: "chrome://browser/content/browser.js" line: 1641}]

Comment 2

[Wesley Johnston (:wesj)]

Attachment: Follow up

Doh. I fixed this to make my addon work. I must have forgotten to qref some changes or something...

Comment 3

[:Margaret Leibovic]

Comment on attachment 785934 [details] [diff] [review]
Follow up

Sorry I didn't catch this in the review!

Comment 4

[Wesley Johnston (:wesj)]

https://hg.mozilla.org/integration/fx-team/rev/ccf62e58c732

Comment 5

[Wesley Johnston (:wesj)]

Comment on attachment 785934 [details] [diff] [review]
Follow up

We need to uplift this to Aurora 25.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 895655
User impact if declined: pages that have reader mode can't be switched to
Testing completed (on m-c, etc.): landed on mc now
Risk to taking this patch (and alternatives if risky): low risk. fix of a stupid mistake
String or IDL/UUID changes made by this patch: none

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/ccf62e58c732

Comment 8

[Wesley Johnston (:wesj)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/f92c84d5826a

Comment 9

[u421692]

Verified as fixed on:
Build: Nightly 26.0a1 (2013-08-19) / Aurora 25.0a2 (2013-08-19)
Device: HTC Desire HD (Android 2.3.5)