Closed
Bug 901543
Opened 11 years ago
Closed 11 years ago
Permanent Orange: TEST-UNEXPECTED-FAIL | test_imapAutoSync.js | 2 == 1
Categories
(MailNews Core :: Build Config, defect)
MailNews Core
Build Config
Tracking
(thunderbird24 fixed, thunderbird25 fixed)
RESOLVED
FIXED
Thunderbird 26.0
People
(Reporter: standard8, Assigned: hiro)
References
Details
(Keywords: intermittent-failure)
Attachments
(1 file)
3.45 KB,
patch
|
standard8
:
review+
standard8
:
approval-comm-aurora+
standard8
:
approval-comm-beta+
|
Details | Diff | Splinter Review |
Seen since the major orange: https://tbpl.mozilla.org/php/getParsedLog.php?id=26156865&tree=Thunderbird-Aurora#error65 TEST-UNEXPECTED-FAIL | /Users/cltbld/talos-slave/test/build/xpcshell/tests/mailnews/imap/test/unit/test_imapAutoSync.js | 2 == 1 - See following stack: JS frame :: /Users/cltbld/talos-slave/test/build/xpcshell/tests/mailnews/imap/test/unit/test_imapAutoSync.js :: endTest :: line 138 JS frame :: ../../../resources/asyncTestUtils.js :: async_run :: line 107 JS frame :: ../../../resources/asyncTestUtils.js :: _async_test_runner :: line 287 JS frame :: ../../../resources/asyncTestUtils.js :: _async_driver :: line 156 JS frame :: /Users/cltbld/talos-slave/test/build/xpcshell/head.js :: do_execute_soon/<.run :: line 444 native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0
Assignee | ||
Comment 1•11 years ago
|
||
This patch includes several fixes. 1. Replace CopyListener with asyncCopyListener. The listeners are totally the same. 2. Remove yield in test_triggerAutoSyncIdle. There is nothing to wait for. 3. Remove async_driver in msgsMoveCopyCompleted. It is redundant because async_driver in asyncCopyListener is the counter part of CopyMessages. 4. Add more yield in test_waitForTargetUpdate. Because the test needs to wait for onDownloadCompleted and onDiscoveryQProcessed.
Assignee: nobody → hiikezoe
Attachment #787958 -
Flags: review?(mbanner)
Assignee | ||
Updated•11 years ago
|
OS: Mac OS X → All
Hardware: x86 → All
Reporter | ||
Comment 2•11 years ago
|
||
Comment on attachment 787958 [details] [diff] [review] fix_for_bug901543.patch Review of attachment 787958 [details] [diff] [review]: ----------------------------------------------------------------- Looks great, thanks!
Attachment #787958 -
Flags: review?(mbanner) → review+
Reporter | ||
Comment 3•11 years ago
|
||
https://hg.mozilla.org/comm-central/rev/53b8331cdedc
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 26.0
Reporter | ||
Comment 4•11 years ago
|
||
Comment on attachment 787958 [details] [diff] [review] fix_for_bug901543.patch [Triage Comment] Taking onto other channels as well.
Attachment #787958 -
Flags: approval-comm-beta+
Attachment #787958 -
Flags: approval-comm-aurora+
Reporter | ||
Comment 5•11 years ago
|
||
https://hg.mozilla.org/releases/comm-aurora/rev/674944f2cb63 https://hg.mozilla.org/releases/comm-beta/rev/72e70055769e
status-thunderbird24:
--- → fixed
status-thunderbird25:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•