Closed
Bug 901544
Opened 11 years ago
Closed 11 years ago
Permanent Orange: TEST-UNEXPECTED-FAIL | test_partsOnDemand.js/test_attachment_size.js | logHelper.js | Error console says [stackFrame NS_ERROR_FAILURE: ...
Categories
(MailNews Core :: MIME, defect)
MailNews Core
MIME
Tracking
(thunderbird24 fixed, thunderbird25 fixed)
RESOLVED
FIXED
Thunderbird 26.0
People
(Reporter: standard8, Assigned: standard8)
References
Details
Attachments
(3 files)
35.26 KB,
patch
|
jcranmer
:
review+
|
Details | Diff | Splinter Review |
4.75 KB,
patch
|
jcranmer
:
review+
|
Details | Diff | Splinter Review |
2.74 KB,
patch
|
jcranmer
:
review+
standard8
:
approval-comm-aurora+
standard8
:
approval-comm-beta+
|
Details | Diff | Splinter Review |
This has been failing since the last major orange: TEST-INFO | (xpcshell/head.js) | test _async_driver finished (2) System JS : ERROR resource://gre/components/nsHandlerService.js:891 NS_ERROR_FAILURE: 'Failure' when calling method: [nsIDirectoryServiceProvider::getFile] TEST-UNEXPECTED-FAIL | ../../../resources/logHelper.js | Error console says [stackFrame NS_ERROR_FAILURE: 'Failure' when calling method: [nsIDirectoryServiceProvider::getFile]] - See following stack: JS frame :: ../../../resources/logHelper.js :: _errorConsoleTunnel.observe :: line 63 native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0
Assignee | ||
Comment 1•11 years ago
|
||
Also in test_attachment_size.js
Summary: Permanent Orange: TEST-UNEXPECTED-FAIL | test_partsOnDemand.js | logHelper.js | Error console says [stackFrame NS_ERROR_FAILURE: ... → Permanent Orange: TEST-UNEXPECTED-FAIL | test_partsOnDemand.js/test_attachment_size.js | logHelper.js | Error console says [stackFrame NS_ERROR_FAILURE: ...
Assignee | ||
Comment 2•11 years ago
|
||
I was looking at this today, there's two parts I'm going to cover here. mailDirService was set up to provide a registration for ProfD to the directory service provider. I was trying to use it to fix this bug and it wasn't working. That's when I discovered that bug 459114 had effectively made mailDirService and all it was designed to do redundant. Hence, we can just drop mailDirService and not have it getting in the way (this should also fix some of the removing directory issues we see on Beta on windows). This patch removes all references to mailDirService.js
Assignee: nobody → mbanner
Attachment #787434 -
Flags: review?(Pidgeot18)
Assignee | ||
Comment 3•11 years ago
|
||
Removes the redundant module.
Attachment #787435 -
Flags: review?(Pidgeot18)
Assignee | ||
Comment 4•11 years ago
|
||
This fixes the tests by setting up a provider for UMimTyp to the directory service. These three patches pushed to try server here: https://tbpl.mozilla.org/?tree=Thunderbird-Try&rev=8cf49469b1ff
Attachment #787439 -
Flags: review?(Pidgeot18)
Updated•11 years ago
|
Attachment #787439 -
Flags: review?(Pidgeot18) → review+
Updated•11 years ago
|
Attachment #787435 -
Flags: review?(Pidgeot18) → review+
Updated•11 years ago
|
Attachment #787434 -
Flags: review?(Pidgeot18) → review+
Assignee | ||
Comment 5•11 years ago
|
||
https://hg.mozilla.org/comm-central/rev/1bd5e4a3b156 https://hg.mozilla.org/comm-central/rev/e151863035fe https://hg.mozilla.org/comm-central/rev/d2fe0ebc74db
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 26.0
Assignee | ||
Comment 6•11 years ago
|
||
Comment on attachment 787439 [details] [diff] [review] Fix the tests - provide UMimTyp [Triage Comment] These three have a=me as they are unit test fixes that we need.
Attachment #787439 -
Flags: approval-comm-beta+
Attachment #787439 -
Flags: approval-comm-aurora+
Assignee | ||
Comment 7•11 years ago
|
||
https://hg.mozilla.org/releases/comm-aurora/rev/cacaee75ce10 https://hg.mozilla.org/releases/comm-aurora/rev/a0bb131ccd75 https://hg.mozilla.org/releases/comm-aurora/rev/f225eb187d5b https://hg.mozilla.org/releases/comm-beta/rev/6ea3bd52c643 https://hg.mozilla.org/releases/comm-beta/rev/d7bd39355035 https://hg.mozilla.org/releases/comm-beta/rev/867c2494fa46
status-thunderbird24:
--- → fixed
status-thunderbird25:
--- → fixed
Assignee | ||
Updated•11 years ago
|
Keywords: intermittent-failure
You need to log in
before you can comment on or make changes to this bug.
Description
•