901801 - 897874 Followup: [Notification] horizontally scrollable with many CB messages

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect, P1)

Description

[(inactive after 6/18) Alive Kuo [:alive]]

See https://bugzilla.mozilla.org/show_bug.cgi?id=897874#c12

Leo found the root cause of CB message notification UI malfunction.

+++ This bug was initially created as a clone of Bug #897874 +++

When there are many CB messages on notification panel, 
the notification panel becomes horizontally scrollable.

The notification item was swiped away to get deleted, however 
the notification panel scrolled horizontally.

It was reported that this issue is not reproducible with SMS, but is reproducible with CB messages.

Comment 1

[(inactive after 6/18) Alive Kuo [:alive]]

Leo could you revise the patch according to https://bugzilla.mozilla.org/show_bug.cgi?id=897874#c14 ?

Comment 2

[hanj.kim25]

(In reply to Alive Kuo [:alive] from comment #1)
> Leo could you revise the patch according to
> https://bugzilla.mozilla.org/show_bug.cgi?id=897874#c14 ?

Yes, I plan to work on it sometime this week.

Comment 3

[Preeti Raghunath(:Preeti)]

Bruce,

Can you please help test this bug? This requires cell broadcast testing.

Thanks!!

Comment 4

[(inactive after 6/18) Alive Kuo [:alive]]

Per comment 2 assign to [e-mail]

Comment 5

[bweng]

Hi Preeti,

To test CBS, we need emulator but we do not have one. After checked with Wayne, we would like to request Leo to verify the fix. 

Thanks.

Comment 6

[Wayne Chang [:wchang]]

Triage - leo partner will take this as follow up to bug 897874.

Partner will also feedback test outcome on this.

Comment 7

[jeremy.kim.leo [:jeremykimleo]]

dear. hanjun
please let us know the result with this patch.

Comment 8

[Leo]

Attachment: Pull request url

Sorry for the delay. Here's the pulll request. 
Please also uplift this to v1-train.
Thanks.

Comment 9

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 789941 [details]
Pull request url

r=me, thanks!

Comment 10

[(inactive after 6/18) Alive Kuo [:alive]]

master
https://github.com/mozilla-b2g/gaia/commit/1aa549b40d714e43846102a5a8b2c996f6493fdf

Comment 11

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted 1aa549b40d714e43846102a5a8b2c996f6493fdf to:
v1-train: 0f1f1ab0ab31a1df8a780baa048b5e7b2854205d

Comment 12

[Tim Guan-tin Chien [:timdream] (please needinfo)]

v1.1.0hd: 0f1f1ab0ab31a1df8a780baa048b5e7b2854205d