902179 - Develop Marionette unit test for OOP get_active_frame

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect)

Description

[Robert Wood [:rwood]]

Develop a marionette (client) unit test to verify that get_active_frame works when using OOP frames.

Comment 1

[Robert Wood [:rwood]]

Attachment: Marionette unit test for OOP getactiveframe

Comment 2

[Jonathan Griffin (:jgriffin)]

Comment on attachment 786640 [details] [diff] [review]
Marionette unit test for OOP getactiveframe

Review of attachment 786640 [details] [diff] [review]:
-----------------------------------------------------------------

Cool, can you add this to the manifest so we can run it on try?  Looks good other than the missing files.

::: testing/marionette/client/marionette/tests/unit/test_getactiveframe_oop.py
@@ +40,5 @@
> +            iframe1.style.height = "100px";
> +            iframe1.style.width = "100%%";
> +            iframe1.src = "%s";
> +            document.body.appendChild(iframe1);
> +            """ % self.marionette.absolute_url("test_oop_1.html"))

need to include test_oop_1.html in the patch (via 'hg add')

@@ +67,5 @@
> +            iframe2.style.height = "100px";
> +            iframe2.style.width = "100%%";
> +            iframe2.src = "%s";
> +            document.body.appendChild(iframe2);
> +            """ % self.marionette.absolute_url("test_oop_2.html"))

need to include test_oop_2.html in the patch

@@ +82,5 @@
> +
> +        # Switch to top-level then back to active frame 2, verify correct frame
> +        self.marionette.switch_to_frame()
> +        self.marionette.switch_to_frame(active_frame2)
> +        self.assertTrue("test_oop_2.html" in self.marionette.get_url())         

nit: extra whitespace at end of line

Comment 3

[Robert Wood [:rwood]]

Attachment: Updated post-review patch

Comment 4

[Jonathan Griffin (:jgriffin)]

Comment on attachment 787088 [details] [diff] [review]
Updated post-review patch

Review of attachment 787088 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good; can you push this to tryserver?  -b do -p linux64,emulator -u marionette,marionette-webapi -t none

Comment 5

[Robert Wood [:rwood]]

Sorry for the delay, pushed to try:
https://tbpl.mozilla.org/?tree=Try&rev=060bb9f83ebc

Comment 6

[Robert Wood [:rwood]]

Didn't look at this for awhile, updated my repo and pushed to try again:
https://tbpl.mozilla.org/?tree=Try&rev=14a2c38e1631

Comment 7

[Robert Wood [:rwood]]

Attachment: 902179update.patch

Failed on try; made a small fix, carrying over the r+

Comment 8

[Robert Wood [:rwood]]

Pushed the new patch to try:
https://tbpl.mozilla.org/?tree=Try&rev=eb9e7e0b98fa

Comment 9

[Robert Wood [:rwood]]

Pushed inbound:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3ed8d1a1b594

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/3ed8d1a1b594