Closed Bug 902352 Opened 11 years ago Closed 11 years ago

Make Gaia keyboard treats the placeholder character U+FFFC as word separator

Categories

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Keyboard
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(blocking-b2g:leo+, b2g18 fixed, b2g-v1.1hd fixed)

Status:
RESOLVED FIXED
Project Flags:
blocking-b2g leo+
Tracking Flags:
Tracking Status
b2g18 --- fixed
b2g-v1.1hd --- fixed

People

(Reporter: xyuan, Assigned: rudyl)

References

Details

Attachments

(1 file)

Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/11548
358 bytes, text/html
timdream
: review+
Details 
This is a followup of bug 883129.

To differentiate non-textual element(such as embeded <iframe>, <image>, <video>...) from the text content of input field, the keyboard API will convert non-textual element as placeholder character U+FFFC.

The gaia keyboard needs some change to treat the placeholder charaster as a word separator, but not a special character belongs to a word.
Does this need to be leo nominated like the original bug?
Yes, please. Without this bug being fixed, the auto-correction function of the keyboard doesn't work properly if there is any attachment beside the word in the MMS message field.
blocking-b2g: --- → leo?
Need to block on this for auto-correction, Tim can you get this assigned?
blocking-b2g: leo? → leo+
Flags: needinfo?(timdream)
Rudy could you help? Should be a trivial change I guess? Do we need help from :djf?
Flags: needinfo?(timdream) → needinfo?(rlu)
Sure, I'll handle this.
Thanks for the heads-up.
Assignee: nobody → rlu
Flags: needinfo?(rlu)
Comment on attachment 790745 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/11548

Hi David,

This is a one-line fix to add U+FFFC as a word separator in latin IME.
Please help review it.

Thank you.
Attachment #790745 - Flags: review?(dflanagan)
Comment on attachment 790745 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/11548

Try to redirect the review to Tim since it seems David is overloaded. :)
 
Hi Tim, 

Could you help on this?
Thank you.
Attachment #790745 - Flags: review?(dflanagan) → review?(timdream)
Attachment #790745 - Flags: review?(timdream) → review+
Gaia master,
be95c3b6757290fff4fdde7a2b73c68f599131a1

v1-train,
6040508a535b587d4155356a47b22d7bd9ea4de7

Tim,

Thanks for the review.
Status: NEW → RESOLVED
Closed: 11 years ago
status-b2g18: --- → fixed
Resolution: --- → FIXED
v1.1.0hd: 6040508a535b587d4155356a47b22d7bd9ea4de7
status-b2g-v1.1hd: --- → fixed
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: