Closed Bug 902398 Opened 11 years ago Closed 11 years ago

Improve the contacts matcher component to report exactly about what fields matched

Categories

(Firefox OS Graveyard :: Gaia::Contacts, defect)

x86
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(blocking-b2g:koi+)

RESOLVED FIXED
blocking-b2g koi+

People

(Reporter: jmcf, Assigned: jmcf)

References

Details

(Whiteboard: [u=commsapps-user c=contacts p=0])

Attachments

(1 file)

We need to improve the Contacts Matcher in order to report clearly about what fields matched. This will be needed to improve the UX according to the latest wireframe specifications, as we will be informing the user why two contacts are matching
blocking-b2g: --- → koi?
Blocks: 895797
Blocks: 902399
Whiteboard: [u=commsapps-user c=contacts p=0]
Attached file 11433.html
requesting review both from Cristian (who will be finally be landing this) and Francisco (main reviewer). Please do not land until Cristian has tested it thoroughly
Attachment #787618 - Flags: review?(francisco.jordano)
Attachment #787618 - Flags: review?(crdlc)
blocking-b2g: koi? → koi+
Attachment #787618 - Flags: review?(francisco.jordano) → review+
As requested in the bug, won't land this until Cristian's test.

Thanks,
F.
Comment on attachment 787618 [details]
11433.html

It works fine finding duplicates and merging from details, editing an existing contact and creating a new one. Good work, r+ from my side
Attachment #787618 - Flags: review?(crdlc) → review+
https://github.com/mozilla-b2g/gaia/commit/8dd9ccd5d1d7b4b5b0a171f6adeaff8ad414eb1d
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: