902416 - [Contacts][Export/Import] Style polish. Adding new icons and CSS tweaks

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Borja Salguero [:borjasalguero]]

We need to add new icons for export/import. This is a follow up for bug 901471 as we need UX input.

Comment 1

[Borja Salguero [:borjasalguero]]

Eric, we would need your help here! We would need import/export/... icons.Thanks!!! :)

Comment 2

[Eric Pang [:epang] UX]

(In reply to Borja Salguero [:borjasalguero] from comment #1)
> Eric, we would need your help here! We would need import/export/...
> icons.Thanks!!! :)

Hi Borja, I'm going to redirect this to Peter since he's the owner of iconography :).

Comment 3

[Borja Salguero [:borjasalguero]]

As well we need to check the height of the buttons in the import panel. Currently is 6rems due to lists.css, but we should update this.

Comment 4

[Peter La]

Hi Eric/Borja,

What icons exactly are needed here? From the IxD spec as well as the visual sent by Vicky, it appears to be using the SIM card icon for import, and Bluetooth icon for export.  Are you looking for more generic icons to represent Import/Export?

Comment 5

[Eric Pang [:epang] UX]

(In reply to Peter La from comment #4)
> Hi Eric/Borja,
> 
> What icons exactly are needed here? From the IxD spec as well as the visual
> sent by Vicky, it appears to be using the SIM card icon for import, and
> Bluetooth icon for export.  Are you looking for more generic icons to
> represent Import/Export?

Borja should be able to provide you with more info. Thanks!

Comment 6

[Borja Salguero [:borjasalguero]]

Hi! Today I'll check icons needed and I'll let you know. Thanks!

Comment 7

[Francisco Jordano [:arcturus] [:francisco]]

Hi folks,

Please Borja correct me if I'm wrong, I think the icon that we were missing was the bluetooth one, and Victoria already provided it.

If anything else is missing please let us know :)

Comment 8

[Borja Salguero [:borjasalguero]]

We need icons for the actions of import/export (currently Im reusing other icons, SIM & SD icons, but probably we need new ones from UX). Peter, could you help us on this? Thanks!

Comment 9

[Borja Salguero [:borjasalguero]]

Restoring the assignment due to my PTO day is over :). Peter, is there any update here?

Comment 10

[Joe Cheng [:jcheng] (please needinfo)]

perhaps epang can help

Comment 11

[Borja Salguero [:borjasalguero]]

Attachment: ExportImport.png

Adding attachment of the screen which need some icons! ;)

Comment 12

[Peter La]

Attachment: Contacts_Import_Export_Icons.zip

Hi Borja/Eric,

Attached are the icons for import contacts / export contacts + a screenshot showing what they look like in context.

Please let me know if you have any concerns or request for changes.

Thanks,
Peter

Comment 13

[Borja Salguero [:borjasalguero]]

Attachment: Problem in other dialogs (send report)

Comment 14

[Borja Salguero [:borjasalguero]]

Comment on attachment 802165 [details]
Problem in other dialogs (send report)

Sorry for the SPAM. THis is for other bug! Im working currently in the patch for the issue of the icons :)

Comment 15

[Borja Salguero [:borjasalguero]]

Attachment: Pull request

Comment 16

[Jose Manuel Cantera]

Comment on attachment 802242 [details]
Pull request

happy to see this fixed, thanks!

Comment 17

[Borja Salguero [:borjasalguero]]

https://github.com/mozilla-b2g/gaia/commit/2a074ca40e9505ceb653e7647041a789d2001102
https://github.com/borjasalguero/gaia/commit/8a12040d49b3e831d87c10b4ff58207801841b84

R+.Merged!

Comment 18

[Borja Salguero [:borjasalguero]]

Thanks Peter for the icons! :)