902959 - GridManager.getApps returns hidden apps

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Description

[Ran Ben Aharon [:ranbena] EverythingMe]

Evme displays apps when typing their name in the searchbar.

Type homescreen/system/keyboard - they appear as installed apps.
These apps are being returned by GridManager.getApps().

This happens on master (HIDDEN_ROLES) and not on v1-train (hiddenapps.js)

Comment 1

[Kevin Grandon :kgrandon]

Attachment: Github pull request pointer

Here's a quick patch...

Comment 2

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 787962 [details]
Github pull request pointer

Sounds good enough to me.

Comment 3

[Kevin Grandon :kgrandon]

Landed in master: https://github.com/mozilla-b2g/gaia/commit/9fbd79dd4b5ca44db13219058f5a3036669db78f

Comment 4

[Ran Ben Aharon [:ranbena] EverythingMe]

Thanks Kevin.

Amir, can you verify this works as expected?

Comment 5

[Amir Nissim (:amirn)]

Homescreen/System/Keyboard are not returned by GridManager.getApps() and does not appear in E.me results - as expected.

However, Communications app is returned by getApps() and appears in E.me results but can not be launched.

Comment 6

[Kevin Grandon :kgrandon]

Attachment: Github Pull Request - Follow up v2

Re-opening the bug and attaching a patch for the follow-up.

Comment 7

[Kevin Grandon :kgrandon]

Comment on attachment 792003 [details]
Github Pull Request - Follow up v2

Cristian - would you be able to give this one a quick review? Thanks!

Comment 8

[Cristian Rodriguez (:crdlc)]

Comment on attachment 792003 [details]
Github Pull Request - Follow up v2

Good work, please review one comment on Github, the rest is perfect as usual! Thanks

Comment 9

[Kevin Grandon :kgrandon]

Thanks for the awesome reviews. Addressed and landed the follow-up in master: https://github.com/mozilla-b2g/gaia/commit/0a22faefa8010f59a375bd65d5abe4bc6eab7fc6

I also noticed that we're not actually displaying individual apps from entry_points in E.me. I will open up another bug to track this.