Closed Bug 903182 Opened 11 years ago Closed 11 years ago

[MP] Defect - URL textbox not showing in appbar in snapped

Categories

(Firefox for Metro Graveyard :: App Bar, defect, P2)

Product:
Firefox for Metro Graveyard
Component:
App Bar
Platform:
x86_64
Windows 8.1
Type:
defect

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
Firefox 26

People

(Reporter: rsilveira, Assigned: rsilveira)

References

Details

(Whiteboard: [preview] feature=defect c=tbd u=tbd p=2)

Attachments

(3 files, 1 obsolete file)

SnappedNoUrlBar.png
3.72 KB, image/png
Details
Patch v2
2.37 KB, patch
ally
: review+
jwilde
: review+
Details | Diff | Splinter Review
screenshot.png
49.35 KB, image/png
Details
Attached image SnappedNoUrlBar.png — 
      No description provided.
Assignee: nobody → rsilveira
Blocks: metrov1it12
Status: NEW → ASSIGNED
Priority: -- → P2
QA Contact: jbecerra
Summary: URL textbox not showing in appbar in snapped → Defect - URL textbox not showing in appbar in snapped
Whiteboard: feature=defect c=tbd u=tbd p=2
Blocks: metrov1it13
No longer blocks: metrov1it12
Attached patch Patch v1 (obsolete) — — Splinter Review 
This patch removes the contextual buttons in snapped view.

It also collapses the hidden buttons on start screen, making the url bar take the extra space.
Attachment #789269 - Flags: review?(ally)
The collapsing of the hidden buttons is for the full screen (not snapped) tracked by bug 903687. Fixed them together because it was the same css selector.
Whiteboard: feature=defect c=tbd u=tbd p=2 → feature=defect c=tbd u=tbd p=2, [preview]
Summary: Defect - URL textbox not showing in appbar in snapped → [MP] Defect - URL textbox not showing in appbar in snapped
Whiteboard: feature=defect c=tbd u=tbd p=2, [preview] → [preview] feature=defect c=tbd u=tbd p=2
So, from my memory of talks with Yuan about bug 903687, we don't want to have the urlbar cover the /entire width/ of the toolbar on either autocomplete or the start screen when we're not snapped. The existing behavior (with the fade between button states and the like) is somewhat more in line with the UX mockups.

However, the new snap view behavior proposed here is fantastic. :D
Yes, after seeing the comps at [1] I think it's better to not widen the url bar, I'll post another patch.

[1] http://people.mozilla.com/~shorlander/files/design-specs-metro/images-design-spec-sheets/Windows8-i03-DesignSpec-%28NavBar%29-i02.jpg
Attached patch Patch v2 — — Splinter Review 
Not messing with fullscreen urlbar width anymore.
Attachment #789269 - Attachment is obsolete: true
Attachment #789269 - Flags: review?(ally)
Attachment #789696 - Flags: review?(jwilde)
Attachment #789696 - Flags: review?(ally)
Comment on attachment 789696 [details] [diff] [review]
Patch v2

Review of attachment 789696 [details] [diff] [review]:
-----------------------------------------------------------------

Seems quite reasonable. jwilde, any objections?
Attachment #789696 - Flags: review?(ally) → review+
Comment on attachment 789696 [details] [diff] [review]
Patch v2

Review of attachment 789696 [details] [diff] [review]:
-----------------------------------------------------------------

Looks awesome to me.
Attachment #789696 - Flags: review?(jwilde) → review+
https://hg.mozilla.org/mozilla-central/rev/b8f0329613e6
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 26
Attached image screenshot.png — 
Mozilla/5.0 (Windows NT 6.2; WOW64; rv:26.0) Gecko/20100101 Firefox/26.0
Build ID: 20130827030201

WFM
Tested using latest Nightly for iteration #13. The URL bar is now visible while in snapped view, as shown in the attached screenshot.
Status: RESOLVED → VERIFIED
OS: Windows 8 Metro → Windows 8.1
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: