903576 - signature summary does not limit certain queries by the product version

Status: RESOLVED FIXED

(Socorro Graveyard :: Middleware, defect)

Description

[Peter Bengtsson [:peterbe]]

The signature summary implementation class does not take the version number into account. 

If you pass `versions=Firefox:8.0` in to the middleware, the queries add a `product_name IN ('Firefox')` bit on the conditionals. However, it does not take the '8.0' into account thus reporting across all versions.

Comment 1

[Peter Bengtsson [:peterbe]]

This class https://github.com/mozilla/socorro/blob/d120ecf17f56924e1238c27e16c8f2e0fdc3b36e/socorro/external/postgresql/signature_summary.py

I'm boldly assigning it to you Selena. I hope you don't mind. 

CC'ing you brandon because you were involved in the first implementation and perhaps you have some valuable views on this to support Selena.

Comment 2

[[github robot]]

Commits pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/d0b042c691e8da4df56e95d3627be8ebed53da60
Fixes bug 903576 and adds version_string to all queries except exploitability

https://github.com/mozilla/socorro/commit/8b797bed7a6c6f227f42d498e6320f4f9053e520
Merge pull request #1399 from selenamarie/bug903576-add-version-to-sigsum

Fixes bug 903576 and adds version_string to all queries except exploitability