Closed
Bug 903682
Opened 11 years ago
Closed 11 years ago
[DeviceStorage] Add an extension for locked music files.
Categories
(Firefox OS Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: Harald, Assigned: dhylands)
Details
Attachments
(1 file)
903 bytes,
patch
|
djf
:
review+
|
Details | Diff | Splinter Review |
Encrypted MP3 as new type generated by the Forward Lock app and played back by the patches Music app. Via Fabrice: Gecko needs to know about mapping the extension to a mime type and the mime type needs to be added to known music files for device-storage.
Comment 1•11 years ago
|
||
This doesn't need to be security-sensitive
Group: core-security
Component: General → Gaia::Music
Comment 2•11 years ago
|
||
Sounds like we would need to modify toolkit/content/devicestorage.properties to include mp3x then.
Component: Gaia::Music → General
Reporter | ||
Updated•11 years ago
|
Group: mozilla-corporation-confidential
Comment 3•11 years ago
|
||
As noted in the parent bug, I think we should use a different filename extension than "mp3x" because we might need to work with locked media formats that are not mp3s. But we can't just add ".fl" to the end of the filename because then we wouldn't be able to distinguish locked music from locked images (though I'm hoping we never have to deal with locked images". A google search indicates that the extension ".lcka" is not in use. We could use that for any "locked audio". Then, if necessary we have .lcki for images and .lckv for videos.
Comment 4•11 years ago
|
||
Editing the summary, nominating for 1.2, and assigning to Dave.
Assignee: nobody → dhylands
blocking-b2g: --- → koi?
Summary: Add .mp3x files to known file types for music → [DeviceStorage] Add an extension for locked music files.
Assignee | ||
Comment 5•11 years ago
|
||
Attachment #791015 -
Flags: review?(dflanagan)
Comment 6•11 years ago
|
||
Unchecking the confidential box. We can implement this in the open. If we need to discuss anything confidential, we can do that in the parent bug 887071.
Group: mozilla-corporation-confidential
Comment 7•11 years ago
|
||
Comment on attachment 791015 [details] [diff] [review] Add .lcka extension as a device storage audio extension Review of attachment 791015 [details] [diff] [review]: ----------------------------------------------------------------- Thanks, Dave!
Attachment #791015 -
Flags: review?(dflanagan) → review+
Assignee | ||
Comment 8•11 years ago
|
||
https://hg.mozilla.org/integration/b2g-inbound/rev/a4d600b4d8ba
Comment 9•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/a4d600b4d8ba
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Updated•11 years ago
|
blocking-b2g: koi? → ---
You need to log in
before you can comment on or make changes to this bug.
Description
•