903754 - Remove InterpreterFrames class and use InterpreterActivation instead

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jan de Mooij [:jandem]]

Attachment: Patch

InterpreterFrames is used to enable interrupts in js::Interpret invocations. The linked list of (interpreter) activations we now have has everything we need though, so there's no need to maintain a second list.

Comment 1

[Jan de Mooij [:jandem]]

Forgot to mention, the patch also removes InterpreterActivation::current_, we can use regs_.fp() instead.

Comment 2

[Luke Wagner [:luke]]

Nice find; I forgot all about this!  Maybe I'm missing a constraint, but could InterpreterActivation just store the switchMask/value directly such that enableInterrupts could *switchMask = value directly?

Comment 3

[Jan de Mooij [:jandem]]

Attachment: Patch v2

(In reply to Luke Wagner [:luke] from comment #2)
> Nice find; I forgot all about this!  Maybe I'm missing a constraint, but
> could InterpreterActivation just store the switchMask/value directly such
> that enableInterrupts could *switchMask = value directly?

Yeah that works. This patch removes the InterruptEnabler stuff as well.

Comment 4

[Luke Wagner [:luke]]

Comment on attachment 789011 [details] [diff] [review]
Patch v2

Great

Comment 5

[Jan de Mooij [:jandem]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/cd086a74f522

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/cd086a74f522