Closed
Bug 903791
Opened 11 years ago
Closed 11 years ago
Make HTMLOptionElement.index infallible
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla26
People
(Reporter: Ms2ger, Assigned: Ms2ger)
References
Details
Attachments
(1 file)
|
5.03 KB,
patch
|
mounir
:
review+
|
Details | Diff | Splinter Review |
In the simple case, GetOptionIndex can't fail.
Attachment #788562 -
Flags: review?(mounir)
|
||
Comment 1•11 years ago
|
||
Comment on attachment 788562 [details] [diff] [review] Patch v1 Review of attachment 788562 [details] [diff] [review]: ----------------------------------------------------------------- In ::Index(), could you define a variable that will be the default returned value. I would like this to be clear that 0 is the value to return when the index is not present. If there is a static const variable, it might make things clearer.
Attachment #788562 -
Flags: review?(mounir) → review+
|
Assignee | |
Comment 2•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/698c66920a41
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
You need to log in
before you can comment on or make changes to this bug.
Description
•