904201 - "noSuchActor" error has no message

Status: RESOLVED FIXED

(DevTools :: Debugger, defect)

Description

[Brandon Benvie [:benvie]]

The "noSuchActor" error packet in `DebuggerServerConnection.prototype.onPacket` has no error message. This makes debugging harder because you have to drill down to look at the packets to see the cause, rather than having a useful message reported in the console.

Comment 1

[Andrei Oprea [:andreio]]

Attachment: bug904201.noSuchActorErrorMsg

You mentioned that there could be multiple causes for this error => multiple error messages. Where could I look for more info ? Thanks

Comment 2

[Brandon Benvie [:benvie]]

Comment on attachment 791235 [details] [diff] [review]
bug904201.noSuchActorErrorMsg

There can be multiple causes, but that doesn't really matter. All the error needs to do is explain what's happening. I think the message you've added does that well enough!

Comment 3

[Andrei Oprea [:andreio]]

Thanks. Is there anything else I need to take care of ?

Comment 4

[Brandon Benvie [:benvie]]

Nope! Thanks.

Comment 5

[Brandon Benvie [:benvie]]

https://tbpl.mozilla.org/?tree=Try&rev=6121e5c84f12

Comment 6

[Brandon Benvie [:benvie]]

https://hg.mozilla.org/integration/fx-team/rev/a2bc0c4ab5bd

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a2bc0c4ab5bd