Closed
Bug 904335
Opened 11 years ago
Closed 11 years ago
sem_post on all exits from the profiler signal handler
Categories
(Core :: Gecko Profiler, defect)
Tracking
()
RESOLVED
FIXED
mozilla26
People
(Reporter: jld, Assigned: jld)
Details
(Keywords: perf, Whiteboard: [c=profiling p=1 s=2013.08.23 u=])
Attachments
(1 file)
|
1014 bytes,
patch
|
BenWa
:
review+
|
Details | Diff | Splinter Review |
When I fixed the signal handler to use a POSIX semaphore instead of a busy loop to signal completion, I neglected to post to the semaphore on the error exit at the top. This should be fixed, though I don't know if we can hit that path in practice, because I tried starting with the profiler enabled with a MOZ_CRASH in it and it did not in fact crash.
Attachment #789322 -
Flags: review?(bgirard)
|
||
Updated•11 years ago
|
Attachment #789322 -
Flags: review?(bgirard) → review+
|
Assignee | |
Updated•11 years ago
|
Keywords: checkin-needed
|
||
Comment 1•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/0543d67043d8
Keywords: checkin-needed
|
||
Comment 2•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/0543d67043d8
Status: NEW → RESOLVED
Closed: 11 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
|
||
Updated•11 years ago
|
Keywords: perf
Whiteboard: [c=profiling p=1] → [c=profiling p=1 s=2013.08.23 u=]
You need to log in
before you can comment on or make changes to this bug.
Description
•