904652 - [OS.File] Port osfile_{win, unix}_allthreads.jsm to worker module loader

Status: RESOLVED FIXED

(Toolkit Graveyard :: OS.File, defect)

Comment 1

[David Teller [:Yoric] - still alive but not very active]

Attachment: 1. Porting osfile_{win, unix}_allthreads.jsm to require()

Comment 2

[David Teller [:Yoric] - still alive but not very active]

Attachment: 1bis. Porting osfile_{win, unix}_allthreads.jsm to require() - ignoring whitespace - DO NOT LAND

Comment 3

[David Teller [:Yoric] - still alive but not very active]

Attachment: 2. Propagating to client modules

Comment 4

[David Teller [:Yoric] - still alive but not very active]

Attachment: 3. Changes to the test suite

Comment 5

[David Teller [:Yoric] - still alive but not very active]

Attachment: 4. Taking the opportunity to improve error message reporting

Comment 6

[David Teller [:Yoric] - still alive but not very active]

Attachment: Merged patch

Same patch, rebased and merged.

Comment 7

[David Teller [:Yoric] - still alive but not very active]

Try: https://tbpl.mozilla.org/?tree=Try&rev=f9ceafa01bfd

Comment 8

[David Teller [:Yoric] - still alive but not very active]

The freezing of object |OS.File| seems to conflict with test_DeferredSave.js
Same patch, minus freeze:
Try: https://tbpl.mozilla.org/?tree=Try&rev=cdb56544ad86

Comment 9

[David Teller [:Yoric] - still alive but not very active]

Attachment: Merged patch, v2

Fixed a few minor errors here and there.
Try: https://tbpl.mozilla.org/?tree=Try&rev=b409cc3a7cad

Comment 10

[David Teller [:Yoric] - still alive but not very active]

Attachment: Merged patch, v3

More unbitrotting.
Try: https://tbpl.mozilla.org/?tree=Try&rev=c9569b4108d2

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/9f16839e91c3

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Backed out for Gaia UI test failures.
https://hg.mozilla.org/integration/fx-team/rev/a5f4a9a55526

https://tbpl.mozilla.org/php/getParsedLog.php?id=28623313&tree=Fx-Team

Comment 13

[Ryan VanderMeulen [:RyanVM]]

And by Gaia UI tests, I meant all B2G tests.

Comment 14

[David Teller [:Yoric] - still alive but not very active]

Oh, looks like I had a |let OS = | that should have been a |this.OS = | due to the different module rules on B2G.

Try: https://tbpl.mozilla.org/?tree=Try&rev=5083c2a75490

Comment 15

[David Teller [:Yoric] - still alive but not very active]

Attachment: Merged patch, v4

Comment 16

[Ryan VanderMeulen [:RyanVM]]

Bitrotted. Please rebase :)

Comment 17

[David Teller [:Yoric] - still alive but not very active]

Attachment: Merged patch, v5

Same patch, unbitrotten.
Try: https://tbpl.mozilla.org/?tree=Try&rev=ca8dff5b84b1

Comment 18

[Ryan VanderMeulen [:RyanVM]]

Thanks :)

https://hg.mozilla.org/integration/fx-team/rev/03d629375717

Comment 19

[Ryan VanderMeulen [:RyanVM]]

Backed out for Windows test bustage (not visible in the last Try push because it was completely busted).
https://hg.mozilla.org/integration/fx-team/rev/4fd49e8f5577

Comment 20

[David Teller [:Yoric] - still alive but not very active]

Attachment: Merged patch, v6

Added bracket lost in unbitrotting.
Try: https://tbpl.mozilla.org/?tree=Try&rev=9c841d14cc3d

Comment 21

[David Teller [:Yoric] - still alive but not very active]

Oh, great, another busted m-c.
Same patch, after repull: https://tbpl.mozilla.org/?tree=Try&rev=915a07ad1d2c

Comment 22

[David Teller [:Yoric] - still alive but not very active]

That might just possibly work better if I remove some Try-specific debugging c++ code that doesn't build anymore.
Try: https://tbpl.mozilla.org/?tree=Try&rev=b73fb41bbff1

Comment 23

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/aa160d21eb25

Comment 24

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/aa160d21eb25