Closed
Bug 90538
Opened 23 years ago
Closed 23 years ago
[mfcEmbed]Downloading files crashes mfcembed.exe
Categories
(Core Graveyard :: Embedding: APIs, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: bmartin, Assigned: chak)
References
Details
(Keywords: crash)
Attachments
(4 files)
28.25 KB,
text/plain
|
Details | |
22.88 KB,
patch
|
Details | Diff | Splinter Review | |
27.99 KB,
patch
|
Details | Diff | Splinter Review | |
2.41 KB,
patch
|
Details | Diff | Splinter Review |
Latest mfcembed dated 07-11-01 O/S: Win2000 System: HP Vectra VL PIII-500MHz 128MB RAM Steps: 1. Download and extract latest embed-win32.zip 2. Launch mfcEmbed.exe 3. Go to http://www.apple.com/quicktime/download/ and try to download QuickTime Results: "Program Error - mfcembed.exe has generated errors and will be closed by windows. You will need to restart the program. An error log is being created." I will attach the error log.
Assignee | ||
Comment 2•23 years ago
|
||
Yet another packaging issue... Works fine from the $DIST/bin dir. However, fails to show the external helper app dialog when run from the Embed packaging dir.
Assignee | ||
Comment 3•23 years ago
|
||
Instead of packaging the XUL files we decided to show embeddors how to override the helper app handling UI.
Assignee | ||
Comment 4•23 years ago
|
||
Assignee | ||
Comment 5•23 years ago
|
||
Assignee | ||
Comment 6•23 years ago
|
||
Hi Dan : Can you r=when you get a chance?
Comment 7•23 years ago
|
||
Rather than building up the factory by hand, you should use the NS_GENERIC_FACTORY_CONSTRUCTOR (here's an example http://lxr.mozilla.org/seamonkey/source/netwerk/build/nsNetModule.cpp#68) macro. That will clean out a lot of boilerplate code. It will also allow for this component to be used in a static build configuration which requires modules to register their factories w/ the macros. nit. In CChooseActionDlg::OnInitDialog()... you can collapse the two "if (mimeInfo)" stmts into one. Just drop the InitW/PerferredAction into the previous "if (mimeInfo)". after the factory change. r=valeski.
Assignee | ||
Comment 8•23 years ago
|
||
Assignee | ||
Comment 9•23 years ago
|
||
Hi Jud : Regarding your comments... 1. Took care of the two "if(mimeinfo)" checks by collapsing into one 2. I'm not able to use the NS_GENERIC_FACTORY_CONSTRUCTOR since i need to pass in an |nsIFactory*| to RegisterFactory()[please see the latest patch]. Since using the NS_GENERIC_FACTORY_CONSTRUCTOR macro depends on the GenericFactory i need to be able to specify the GenericFactory in the call to RegisterFactory. - I'm not sure how to get an interface pointer to the GenericFactory Guess that's why Danm's using the non-generic factory approach to override the PromptService as well. Thanks
Comment 10•23 years ago
|
||
hmmm. sounds like a deficiency, but what you're saying makes sense. r=valeski.
Assignee | ||
Comment 11•23 years ago
|
||
Hi Chris : Can i get an sr= when you get a chance...Thanks
Status: NEW → ASSIGNED
Comment 12•23 years ago
|
||
sr=blizzard
Assignee | ||
Comment 13•23 years ago
|
||
Fix has been checked in....
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 14•23 years ago
|
||
*** Bug 57884 has been marked as a duplicate of this bug. ***
Updated•5 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•