905448 - Disabling keyword.enabled and entering a wrong URI assert

Status: RESOLVED FIXED

(Core :: DOM: Navigation, defect)

Description

[Tom S [:evilpie]]

So I noticed this, because at the moment child processes can't do proper URIFixup. But the problem can be reproduce on a normal build by setting keyword.enabled to false and entering "bla bla" into the urlbar.

0x00007ffff05e5468 in nsDocShell::CreateContentViewer (this=0x7fffc9974800, aContentType=0x7fffc74221c8 "application/xhtml+xml", request=0x7fffca9bd8f0, aContentHandler=0x7fffc7471588)
    at /home/tom/mozilla-inbound/docshell/base/nsDocShell.cpp:8008
8008	        MOZ_ASSERT(failedURI, "We don't have a URI for history APIs.");

This seems to happen, because Stop resets mFailedURI before we end up in CreateContentViewer. I think this was caused by Bug 382702.

Comment 1

[Tom S [:evilpie]]

Attachment: possible fix?

This doesn't seem much worse than what we had before and ensures that this assert doesn't happen. Only downside is a blank page in your history, but that would probably also happen when the old code worked.

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 790806 [details] [diff] [review]
possible fix?

Yeah, I think we can do this. 
nsDocShell::LoadErrorPage is not exactly beautiful code. 
Oddity from 2002.

Comment 3

[Tom S [:evilpie]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/9fd000703ace

Comment 4

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/9fd000703ace