906372 - crash in js::WorkerThreadState::finishParseTaskForScript(JSScript*)

Status: RESOLVED FIXED

(Core :: General, defect)

Description

[Alice0775 White]

This bug was filed from the Socorro interface and is 
report bp-da9ab953-b30a-47e8-a137-1fcee2130817 .
 ============================================================= 

Steps To Reproduce:
1. Install https://addons.mozilla.org/en-US/firefox/addon/easiest-youtube-video-downl/
2. Restart

Actual Results:
 Browser crashes at start up

Regression window(m-i)
Good:
http://hg.mozilla.org/integration/mozilla-inbound/rev/d52251e9123c
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:26.0) Gecko/20100101 Firefox/26.0 ID:20130815125919
Bad:
http://hg.mozilla.org/integration/mozilla-inbound/rev/b5e301863e69
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:26.0) Gecko/20100101 Firefox/26.0 ID:20130815141517
Pushlog:
http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=d52251e9123c&tochange=b5e301863e69

Regressed by:
b5e301863e69	Brian Hackett — Bug 897655 - Use off thread parsing when loading scripts from XUL documents, r=billm,bz,luke.

Comment 1

[Alice0775 White]

Windows7 bp-455c8b9f-c5ca-4259-8551-8989d2130817
Ubuntu   bp-1b8ccc86-005c-4b49-85d2-11e892130817

Comment 2

[Brian Hackett [Laid off!]]

Attachment: patch

The very first thing WorkerThreadState::finishParseTaskForScript does is dereference its script parameter, which will be NULL if the parse failed.

Comment 3

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Comment on attachment 791752 [details] [diff] [review]
patch

Review of attachment 791752 [details] [diff] [review]:
-----------------------------------------------------------------

Could you look into ways of writing tests for some of these bugs that are popping up? It seems like this one should be relatively easy to test with the right harness. I'm not sure about the other ones.

Comment 4

[Brian Hackett [Laid off!]]

I'll ask around next week about writing a mochitest for this.

https://hg.mozilla.org/integration/mozilla-inbound/rev/4649bb1224f6

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/4649bb1224f6