906402 - security exception when checking signature of favicon (?)

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[martin]

Attachment: logcat_except_gecko.txt

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:23.0) Gecko/20100101 Firefox/23.0 (Beta/Release)
Build ID: 20130803215302

Steps to reproduce:

Searched websites with "startpage (SSL)" add-on installed. Clicked on any search result.


Actual results:

Logcat shows security exceptions with every website loading.


Expected results:

On the surface everything works as expected. I just worry about the exceptions.

Comment 1

[Aaron Train [:aaronmt]]

Do you see these when you disable "Startpage (SSL)" ?

Comment 2

[martin]

Hi Aaron!

I disabled every add-on and the culprit is "adblock plus". How can I provide further information? Should I contact the developer of "adblock plus"?

Greetz
Martin

Comment 3

[Aaron Train [:aaronmt]]

It is suggested to file a bug-report over at https://adblockplus.org/forum/viewforum.php?f=11; if the case be that it's an issue on our end discovered in comment, I would imagine we could re-open this.

Comment 4

[Mark Capella [:capella]]

I had filed this previously ... sounds like a dup and we should close that too
https://bugzilla.mozilla.org/show_bug.cgi?id=901939

Comment 6

[Wladimir Palant]

(In reply to Aaron Train [:aaronmt] from comment #3)
> It is suggested to file a bug-report over at
> https://adblockplus.org/forum/viewforum.php?f=11;

I disagree - this isn't an Adblock Plus bug. Adblock Plus has been signed correctly but that's not really the point. The problem here is rather that Firefox shouldn't attempt to validate the signature when displaying the extension icon. For reference, the corresponding bug in the desktop Firefox version is bug 726125 which has been resolved a while ago.

Note that my comment is based on the description from bug 901939 which has been resolved as a duplicate of this one - there isn't much of a description here.

Comment 7

[Mark Capella [:capella]]

Attachment: bug906402 (v0)

If you're saying that we can assume extension icons are trusted sources, we can bypass the security check done in Java and provide a working patch for consideration this way.

Comment 8

[Mark Capella [:capella]]

Comment on attachment 820696 [details] [diff] [review]
bug906402 (v0)

Ping mfinkle for feedback, not sure who to check with otherwise

Comment 9

[Mark Capella [:capella]]

Attachment: bug906402 (v1)

new version tightens it up a bit

Comment 10

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 821632 [details] [diff] [review]
bug906402 (v1)

>+                        // Addons, extensions, etc

Let's make the comment a bit more descriptive:

// Don't attempt to validate the JAR signature when loading an add-on icon

Comment 11

[Mark Capella [:capella]]

TRY is nice and green: https://tbpl.mozilla.org/?tree=Try&rev=83e7ed66547f

Comment 12

[Mark Capella [:capella]]

And on we go https://hg.mozilla.org/integration/fx-team/rev/06e480dedcb0
Adblock plus icons for everyone

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/06e480dedcb0