906741 - Compose window doesn't completely dismiss after sending a message in fullscreen

Status: RESOLVED FIXED

(Thunderbird :: Message Compose Window, defect)

Description

[ekrem.koc]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:23.0) Gecko/20100101 Firefox/23.0 (Beta/Release)
Build ID: 20130814063812

Steps to reproduce:

Mac OS X 10.8.4.

I often use full screen for Mozilla Thunderbird. I write a new compose and this window is full screen and is the desktop is another place.


Actual results:

When I have sent a compose to someone, than I see that a window is black.


Expected results:

Can the development make: a desktop go close after I sent a compose?

Comment 1

[ekrem.koc]

I have made screenshot:
http://picpaste.com/pics/Schermafbeelding_2013-08-19_om_20.49.29-RfADRTQm.1376938430.png

After I sent a compose, I saw a black desktop. Why didn't the desktop close?

Comment 2

[Wayne Mery (:wsmwk)]

see this with beta version from http://www.mozilla.org/thunderbird/channel/ ?

Comment 3

[ekrem.koc]

Attachment: tb 24 beta.png

Comment 4

[ekrem.koc]

Attachment: earlybird 25 nightly.png

Comment 5

[ekrem.koc]

@Wayne, 24 and 25 TB doesnt work too )-: see attachment

Comment 6

[ekrem.koc]

If I close an address book window (full screen), than is the desktop close too. Why doesn't  the desktop close after the compose window go send or close?

Comment 7

[Josiah Bruner [:jsbruner]]

Yep, I'm seeing this too.

Comment 8

[Thomas D. (:thomas8)]

(In reply to Josiah Bruner [:JosiahOne] from comment #7)
> Yep, I'm seeing this too.

Josiah, could you pls add steps to reproduce? Is "fullscreen" a special feature of MAC OS windows?

Comment 9

[Josiah Bruner [:jsbruner]]

(In reply to Thomas D. from comment #8)
> (In reply to Josiah Bruner [:JosiahOne] from comment #7)
> > Yep, I'm seeing this too.
> 
> Josiah, could you pls add steps to reproduce? Is "fullscreen" a special
> feature of MAC OS windows?

Sure thing.

This "fullscreen" is a Cocoa (OS X) API that we use for certain windows (including this one). My guess is that the compose window dismissal forgot about this serparate behavior when it was developed. So although the window is closed, we still need to dismiss the fullscreen state. It's possible that this needs to be done on the widget end of things, since usually OS X applications aren't closed while in fullscreen mode.

STR are simple enough:

Open compose window
Click the fullscreen button in the top right corner of the window
Send message.
Examine behavior.

Fix:

I'll probably do this when I have a chance, but in case anyone wants to take a stab, the idea is simple.

Before we close the window, exit the fullscreen state using Cocoa's enterFullScreen:withOptions: method. We might have a way to accomplish the same method via JS, but I wouldn't know what it is off the top of my head.

Comment 10

[ekrem.koc]

I see that works it; a desktop go close after I sent a compose to someone. Maybe I have adjusted a configuration editor. I had disable all:
- full-screen-api.allow-trusted-requests-only
- full-screen-api.content-only;true
- full-screen-api.enabled
- full-screen-api.pointer-lock.enabled

Comment 11

[ekrem.koc]

Can someone fix this bugs please?

Comment 12

[Josiah Bruner [:jsbruner]]

Attachment: Fix.

This should fix the issue.

Comment 13

[Josiah Bruner [:jsbruner]]

Mike, so what we were trying yesterday (Well, today, but it will be tomorrow when you read this), didn't work.

Apparently we've lost reference to the window object by DoCommandClose() or something similar, because I can not toggle fullscreen off at that point.

We may still have to use the current solution, but I'm open to other ideas.

Comment 14

[Josiah Bruner [:jsbruner]]

By the time we arrive at DoCommandClose() I mean.

Comment 15

[Magnus Melin [:mkmelin]]

Comment on attachment 8428471 [details] [diff] [review]
Fix.

Review of attachment 8428471 [details] [diff] [review]:
-----------------------------------------------------------------

Don't have a mac, but this looks totally reasonable to me. r=mkmelin

Comment 16

[Josiah Bruner [:jsbruner]]

Thanks.

Comment 17

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/comm-central/rev/fa19c31d7e11

Comment 18

[Josiah Bruner [:jsbruner]]

Comment on attachment 8428471 [details] [diff] [review]
Fix.

[Approval Request Comment]
Regression caused by (bug #): OS X Lion
User impact if declined: Trying to send a message while in full screen will not dismiss the space, forcing the user to dismiss the space themselves.
Testing completed (on c-c, etc.): On comm-beta.
Risk to taking this patch (and alternatives if risky): Very low, minimal JS patch and has been on c-c, c-a, and c-b already.

Comment 20

[Mark Banner (:standard8)]

https://hg.mozilla.org/releases/comm-esr31/rev/a1b85b767fd6