Closed
Bug 906772
Opened 11 years ago
Closed 11 years ago
[MP] Defect - popup blocked notification bar is hidden behind the navbar
Categories
(Firefox for Metro Graveyard :: Browser, defect, P2)
Tracking
(Not tracked)
VERIFIED
FIXED
Firefox 26
People
(Reporter: Samvedana, Assigned: emtwo)
References
Details
(Whiteboard: [preview] feature=defect c=info_app_bar u=metro_firefox_user p=1)
Attachments
(1 file)
|
1.61 KB,
patch
|
mbrubeck
:
review+
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (Windows NT 6.2; WOW64; rv:26.0) Gecko/20100101 Firefox/26.0 Build ID: 20130819030205 Built from http://hg.mozilla.org/mozilla-central/rev/c8c9bd74cc40 Tested on windows 8 using latest nightly for iteration-12. Steps: 1. Go to http://www.popuptest.com/popuptest1.html Expected: A pop-up blocker info app bar Actual: Nothing happens. It just loads a page.
|
||
Updated•11 years ago
|
Whiteboard: [preview-triage] feature=defect c=tbd u=tbd p=0
|
|
||
Updated•11 years ago
|
Blocks: MetroPreviewRelease
Summary: Defect - popup behavior is inconsistent → [MP] Defect - popup behavior is inconsistent
Whiteboard: [preview-triage] feature=defect c=tbd u=tbd p=0 → [preview] feature=defect c=tbd u=tbd p=0
|
||
Comment 2•11 years ago
|
||
Not sure bug 908096 was a complete duplicate. Just to clarify: the behavior described there is not inconsistent, is consistently wrong (no infobar when the new unfocused tab tries to open pop-ups).
|
||
Updated•11 years ago
|
Summary: [MP] Defect - popup behavior is inconsistent → [MP] Defect - popup blocked notification bar is hidden behind the navbar
|
||
Comment 3•11 years ago
|
||
Related to bug 883953. I think we need to make sure to call ContentAreaObserver.updateContentArea whenever a notification is added or removed.
Blocks: 883953
Whiteboard: [preview] feature=defect c=tbd u=tbd p=0 → [preview] feature=defect c=tbd u=tbd p=0 [shovel-ready]
|
|
||
Updated•11 years ago
|
Assignee: nobody → msamuel
Status: NEW → ASSIGNED
Priority: -- → P2
QA Contact: jbecerra
Whiteboard: [preview] feature=defect c=tbd u=tbd p=0 [shovel-ready] → [preview] feature=defect c=tbd u=tbd p=1
|
Assignee | |
Comment 4•11 years ago
|
||
We already have calls to ContentAreaObserver.updateContentArea() for when navbars appear after infobars. This patch adds calls to updateContentArea() for when infobars appear after navbars.
Attachment #801660 -
Flags: review?(mbrubeck)
|
|
||
Updated•11 years ago
|
|
|
||
Updated•11 years ago
|
Attachment #801660 -
Flags: review?(mbrubeck) → review+
|
|
Assignee | |
Comment 5•11 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/40290b0fa14a
Whiteboard: [preview] feature=defect c=tbd u=tbd p=1 → [fixed-in-fx-team][preview] feature=defect c=tbd u=tbd p=1
|
||
Comment 6•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/40290b0fa14a
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team][preview] feature=defect c=tbd u=tbd p=1 → [preview] feature=defect c=tbd u=tbd p=1
Target Milestone: --- → Firefox 26
|
||
Updated•11 years ago
|
Whiteboard: [preview] feature=defect c=tbd u=tbd p=1 → [preview] feature=defect c=info_app_bar u=metro_firefox_user p=1
|
||
Comment 7•11 years ago
|
||
While testing this for iteration #15, with latest Nightly (build ID: 20130926145500), I can see the pop-up blocker info app bar. On the other hand, after opening the URL, and immediately opening a new tab, when I go back to the tab with http://www.popuptest.com/popuptest1.html loaded, I can't see the app bar anymore. Is this expected?
Flags: needinfo?(msamuel)
|
|
Assignee | |
Comment 8•11 years ago
|
||
I believe our popups disappear as soon as you click anywhere outside of them so opening a new tab may result in that. Please correct me if I'm wrong, Matt?
Flags: needinfo?(msamuel) → needinfo?(mbrubeck)
|
|
||
Comment 9•11 years ago
|
||
(In reply to Marina Samuel [:emtwo] from comment #8) > I believe our popups disappear as soon as you click anywhere outside of them > so opening a new tab may result in that. Please correct me if I'm wrong, > Matt? Yes, the "Blocked pop-up" notification is intentionally transient and goes away if you tap elsewhere (see bug 847620 comment 2).
Flags: needinfo?(mbrubeck)
|
|
||
Comment 10•11 years ago
|
||
Marking this as verified, based on comment 7, comment 8 and comment 9. Thanks Marina & Matt!
Status: RESOLVED → VERIFIED
|
||
Updated•10 years ago
|
OS: Windows 8 Metro → Windows 8.1
You need to log in
before you can comment on or make changes to this bug.
Description
•