90686 - Can't migrate profiles under OS X

Status: VERIFIED FIXED

(Core Graveyard :: Profile: BackEnd, defect)

Description

[Conrad Carlen (not reading bugmail)]

When finding 4x profiles to migrate, we look in SystemFolder:Preferences: See:
http://lxr.mozilla.org/mozilla/source/profile/src/nsProfile.cpp#1770. Running
under OS X, that folder location is meaningless. It is possible under OS X to
specify that ::FindFolder(...) should look in the Classic environment on that
machine. There, we would find :Preferences: and thus 4x profiles.

Comment 1

[Conrad Carlen (not reading bugmail)]

I think this should be OSX+.

Comment 2

[Conrad Carlen (not reading bugmail)]

-> 0.9.4

Comment 3

[Conrad Carlen (not reading bugmail)]

Attachment: Patch to allow Classic Prefs folder to be found under OS X

Comment 4

[Conrad Carlen (not reading bugmail)]

Migration works with this patch because, when asked for the Preferences folder
under OS X, it will look in the Classic domain. I just added this behavior for
prefs because I don't think we should do this in general.

Comment 5

[Conrad Carlen (not reading bugmail)]

Steve, Simon - Can you r=/sr=?

Comment 6

[Steve Dagley]

as long as we're only doing it for pref migration, r=sdagley

Comment 7

[Simon Fraser [no longer active]]

sr=sfraser

Comment 8

[Conrad Carlen (not reading bugmail)]

Fix checked in.

Comment 9

[Grace Bush]

verified on build 2001081405