906918 - Use MoveRef's in nsTHashtable

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Justin Lebar (not reading bugmail)]

See patch in a moment.

Comment 1

[Justin Lebar (not reading bugmail)]

Attachment: Use MoveRef's in nsTHashtable.

This patch adds a move constructor for nsTHashtable and also lets
nsTHashtable use its EntryType's move constructor, if one is available.

This patch also adds move constructors for nsCharPtrHashKey and
nsUnicharPtrHashKey.  Using these new constructors, nsTHashtable will be
able to avoid strdup()'ing all of its keys whenever it resizes the
table.

Comment 2

[Justin Lebar (not reading bugmail)]

Waldo et al., thanks a lot for moving Move into mfbt.  This is a really powerful abstraction.

Comment 3

[Jeff Walden [:Waldo]]

I see what you did there.

Comment 4

[Justin Lebar (not reading bugmail)]

Thanks!

https://hg.mozilla.org/integration/mozilla-inbound/rev/7b925807955c

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/7b925807955c

Comment 6

[(no longer active)]

Hmm, can we use C++11 move() here as well?