907522 - Uplift Add-on SDK code to mozilla-aurora to fix frequent intermittent test failures

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect)

Description

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

We should uplift the recent fixes for the SDK's intermittent test failures to Aurora and Beta to clean up our tests before they hit the ESR branch or get disabled for being too noisy.

Comment 1

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

One option would be to just take our git repository's firefox26 branch and merge it down to firefox25 and uplift all of that to Aurora (so Aurora and current-Central have identical code), and just cherry-pick individual test fixes/disables to firefox24 and uplift that to Beta.

This should significantly green up Aurora and Beta, while not doing too many risky changes on Beta. We still have a few months to catch any fallout before Firefox 25 releases in mid-October.

Jeff, Dave, Irakli: What do you think?

Comment 2

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

(In reply to Wes Kocher (:KWierso) from comment #1)
> One option would be to just take our git repository's firefox26 branch*

* once we're reasonably sure we are no longer breaking things from bug 906682

Comment 3

[Ryan VanderMeulen [:RyanVM]]

FWIW, Jetpack is actually reasonably green on beta (Fx24), so cherry-picking some fixes to harden things seems like a good way to go IMO.

Comment 4

[Ed Morley [:emorley]]

Thank you for filing this Wes! :-)

Comment 5

[Dave Townsend [:mossop]]

The changelog for firefox25..firefox26 is https://github.com/mozilla/addon-sdk/compare/firefox25...firefox26

It's large because all of the UX work is in there, but it shouldn't be active since australis isn't there. There are a few changes to match m-c changes, like indexeddb fixes, a good first step would be to make sure that landing all that stuff on aurora actually passes tests.

I'm not entirely opposed but a little wary of landing so much without having been through all those changesets with a fine toothcomb yet.

Comment 6

[Dave Townsend [:mossop]]

Started a try run: https://tbpl.mozilla.org/?tree=Try&rev=f998c39331c5

Comment 7

[Dave Townsend [:mossop]]

Looks like at the very least the devtools console changes are breaking us.

I think since we have to cherry-pick fixes for beta we might as well just land those same fixes on aurora too rather than going for the fuller uplift. I'll look at which fixes to take tomorrow.

Comment 8

[Dave Townsend [:mossop]]

This is what I'll propose for aurora once the try runs are in: https://github.com/Mossop/addon-sdk/compare/firefox25. Assuming that all passes I'll check that the same changes apply to beta.

Comment 9

[Dave Townsend [:mossop]]

In terms of beta uplift, I've attempted to cherry-pick those same changesets and it is so different that it becomes painful fast. So instead I looked to see what tests are particularly harming the beta branch to maybe only cherry-pick fixed for those. But the beta branch looks entirely green and brasstacks claims that there are no real test failures there. Am I missing something?

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Nope, see comment 3 :). If there aren't any easy cherry picks for beta, I'm OK with leaving things as-is for now. If at some point we do find some test to be problematic, we can always address it then.

Comment 11

[Dave Townsend [:mossop]]

Ok let's just stick with aurora for now

Comment 12

[Dave Townsend [:mossop]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/2e36e2efcfe2

Comment 13

[Dave Townsend [:mossop]]

I think we're done here