907631 - [contacts] use mocks helper and proper mocks in vcard tests

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Julien Wajsberg [:julienw]]

Current vcard tests are not using proper mocks for mozContact. Therefore it's relying on the browser helper extension, and it's not really "unit". And it will break when bug 905775 will land.

Comment 1

[Julien Wajsberg [:julienw]]

Attachment: patch v1

PR is at https://github.com/mozilla-b2g/gaia/pull/11658. I pushed also the commit for bug 905775 so that travis can run until the end, so please don't merge the PR direcly.

We can also see the difference between the previous travis run in https://travis-ci.org/mozilla-b2g/gaia/builds/10444558 and the new travis run in https://travis-ci.org/mozilla-b2g/gaia/builds/10445673

Comment 2

[Julien Wajsberg [:julienw]]

When discussed with Alexandre Poirot, maybe we should have the mozContact constructor in our test environment anyway.

I don't know if we should use a mock for this object since it's not (really) an API (or is it ?).

Comment 3

[Francisco Jordano [:arcturus] [:francisco]]

As you comment Julien, I'm still not sure about this change, I'm checking the comments you and more folks are having around bug 905775 and seems it's not clear, should we wait till we have a final decision for that bug?

Comment 4

[Julien Wajsberg [:julienw]]

Yep we can wait for bug 905775 but I think we're moving towards landing it as is. Probably my patch here should not be necessary in an ideal world but it doesn't break much either so probably better land it too.

Comment 5

[Julien Wajsberg [:julienw]]

So, Bug 905775 landed in its original form, therefore I'd like to land this as well.

What do you think Francisco ?

Comment 6

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 793405 [details] [diff] [review]
patch v1

Review of attachment 793405 [details] [diff] [review]:
-----------------------------------------------------------------

Just tried this against latest master, with the proper config DEBUG=1 DESKTOP=0 and working perfectly.

Julien thanks again for your help here, is really appreciated :)

Cheers,
F.

Comment 7

[Julien Wajsberg [:julienw]]

master: 58be0d12c96cbc9f2c9b1b83adad4ce5d92bee65