907766 - Come up with a solution for routes overrides

Status: RESOLVED FIXED

(Webmaker Graveyard :: Popcorn Maker, defect)

Description

[Ali Al Dallal [:alicoding]]

Right now we only have a quick fix for overriding the path for all the templates files.

Comment 1

[Zakeria Hassan]

Hi,

Interesting bug. If no one is working on this. Assign this one to me.

Thanks,
Zak

Comment 2

[Ali Al Dallal [:alicoding]]

You can flag Matthew Schranz [:mjschranz] for review after you have complete this bug. Thanks @Zakeria.

Comment 3

[Ali Al Dallal [:alicoding]]

More context of this bug. See https://github.com/mozilla/popcorn.webmaker.org/blob/master/server.js#L243-L266 we want to be able to route to all these but without having to write 20+ lines of code in the server.js 

This is how we have done it for Thimble https://github.com/mozilla/thimble.webmaker.org/blob/master/routes/index.js#L54-L92 

https://github.com/mozilla/thimble.webmaker.org/blob/master/app.js#L271

It'd be great to have it better than Thimble if you can find a way else the same with Thimble should be acceptable (Preferable something better :P ).

Comment 4

[Jon Buckley [:jbuck]]

Move the files into the views directory?

Comment 5

[Ali Al Dallal [:alicoding]]

Assigning this to myself for now.

Comment 6

[Ali Al Dallal [:alicoding]]

Attachment: https://github.com/mozilla/popcorn.webmaker.org/pull/525

Comment 7

[Scott [:thecount] Downe]

Comment on attachment 8397372 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/525

I added a comment with how you can reduce this, by changing up the directory structure to something easier. If it doesn't make sense, feel free to ask questions.

You can decide to go this way or not, really, what you have is fine too :)

Comment 8

[Scott [:thecount] Downe]

Comment on attachment 8397372 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/525

Yeah, looks much better.

Comment 9

[[github robot]]

Commit pushed to master at https://github.com/mozilla/popcorn.webmaker.org

https://github.com/mozilla/popcorn.webmaker.org/commit/b5870cb6d846b4806718155e760889dc7113720a
bug907766 - Solution to route override