907837 - ImageContainer.h:11:10: fatal error: GeckoProfilerFunc.h' file not found (non-SPS)

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[Jan Beich]

On platforms without SPS profiler the build is broken due to
GeckoProfilerFunc.h not being exported.

gfx/gl/GLContext.cpp:14:
In file included from dist/include/gfxUtils.h:12:
dist/include/ImageContainer.h:11:10: fatal error:
GeckoProfilerFunc.h' file not found
#include "GeckoProfilerFunc.h"          // for TimeStamp
         ^

Comment 1

[Jan Beich]

Attachment: remove bogus include

TimeStamp and TimeDuration are in mozilla/TimeStamp.h while *_sampler_* functions defined in GeckoProfilerFunc.h are unused in those files.

Comment 2

[Jan Beich]

Attachment: use stable header

Comment 4

[Landry Breuil (:gaston)]

I'm puzzled because i dont see that failure, and we dont have the SPS profiler on OpenBSD..

Comment 5

[Benoit Girard (:BenWa)]

Thanks nick!

Comment 6

[Landry Breuil (:gaston)]

And now i know why i didnt see that failure... since 903816/Include-what-you-use landed, the two patches dont apply anymore, and are not needed ? Removing checkin-needed until someone sorts this out....

Comment 7

[Nick Cameron [:nrc]]

(In reply to Landry Breuil (:gaston) from comment #6)
> And now i know why i didnt see that failure... since
> 903816/Include-what-you-use landed, the two patches dont apply anymore, and
> are not needed ? Removing checkin-needed until someone sorts this out....

I think the problem is caused by 903816 and these patches fix it. They should apply now.

Comment 8

[Nick Cameron [:nrc]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2ed38ca05fd2
https://hg.mozilla.org/integration/mozilla-inbound/rev/806a989ec3ad

Comment 9

[Landry Breuil (:gaston)]

Ok, disregard my remark then. I tried applying/pushing those two commits this morning, and failed. Maybe a local thing with my m-i clone. And i finally saw the same failure on some of my builders....

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/2ed38ca05fd2
https://hg.mozilla.org/mozilla-central/rev/806a989ec3ad