Closed
Bug 90791
Opened 23 years ago
Closed 23 years ago
hashtables of one (or occasionally two) elements!
Categories
(Core :: CSS Parsing and Computation, defect, P1)
Core
CSS Parsing and Computation
Tracking
()
VERIFIED
FIXED
mozilla0.9.3
People
(Reporter: dbaron, Assigned: dbaron)
Details
(Keywords: perf)
Attachments
(1 file)
6.15 KB,
patch
|
Details | Diff | Splinter Review |
mMediumCascadeTable in nsCSSStyleSheet is a table mapping media atoms to rule cascades. We generally have one medium ("screen"), although occasionally we have a second ("print"). I'll attach a patch to make it a linked list, but I imagine this will greatly improve the performance of GetRuleCascade for the case where we already have a rule cascade cached. (I'll profile shortly...)
Assignee | ||
Updated•23 years ago
|
Assignee | ||
Comment 1•23 years ago
|
||
Assignee | ||
Comment 2•23 years ago
|
||
Yeah, this cut about 40% of the time out of GetRuleCascade (so that it takes a lot less time all but the first time it's called).
Comment 3•23 years ago
|
||
Looks like a good change. I also likes patches that removes more lines than they add. :-)
Comment 4•23 years ago
|
||
r=waterson
Comment 5•23 years ago
|
||
sr=attinasi
Assignee | ||
Comment 6•23 years ago
|
||
Fix checked in 2001-07-16 13:59 PDT.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 9•23 years ago
|
||
Yes, see my 2001-07-14 comments.
You need to log in
before you can comment on or make changes to this bug.
Description
•