Closed Bug 90791 Opened 23 years ago Closed 23 years ago

hashtables of one (or occasionally two) elements!

Categories

(Core :: CSS Parsing and Computation, defect, P1)

defect

Tracking

()

VERIFIED FIXED
mozilla0.9.3

People

(Reporter: dbaron, Assigned: dbaron)

Details

(Keywords: perf)

Attachments

(1 file)

mMediumCascadeTable in nsCSSStyleSheet is a table mapping media atoms to rule
cascades.  We generally have one medium ("screen"), although occasionally we
have a second ("print").  I'll attach a patch to make it a linked list, but I
imagine this will greatly improve the performance of GetRuleCascade for the case
where we already have a rule cascade cached.  (I'll profile shortly...)
Status: NEW → ASSIGNED
Keywords: perf
Priority: -- → P1
Target Milestone: --- → mozilla0.9.3
Yeah, this cut about 40% of the time out of GetRuleCascade (so that it takes a
lot less time all but the first time it's called).
Looks like a good change. I also likes patches that removes more lines than they 
add. :-)
r=waterson
sr=attinasi
Fix checked in 2001-07-16 13:59 PDT.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
This caused the regresion at bug 93106
was there any profile on the perf improvements?
Yes, see my 2001-07-14 comments.
verified as per comments
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: