908517 - zffos1.1 There is no low battery warning.

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: General, defect)

Description

[ji.chen5]

User Agent: Mozilla/4.0 (compatible; MSIE 8.0; Windows NT 5.1; Trident/4.0; CIBA; .NET CLR 2.0.50727; .NET CLR 3.0.4506.2152; InfoPath.2; .NET4.0C; .NET4.0E; .NET CLR 3.5.30729; TCO_20130823084927)

Comment 1

[Ivan Tsay (:ITsay)]

Hi Chen,

This one seems to be duplicated to 909174. Please help to check.

Comment 3

[gbennett]

I am unable to repro this issue on these two builds:

Environmental Variables
Device: Unagi 1.1.0
Build ID: 20130830041201
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/2fb19341d934
Gaia: 577ab5105af418efc8ded00798fd3644b3dac674
Platform Version: 18.1

Environmental Variables
Device: Unagi 1.2.0.0
Build ID: 20130830162255
Gecko: http://hg.mozilla.org/mozilla-central/rev/cfe8b0ab6d59
Gaia: 46dcd65c2075f0872a4597169ad9c9f7bdba0335
Platform Version: 26.0a1

I ran youtube videos until the battery was reduced to 10% and at that percent a prompt/warning appeared for low battery.
Let me know if you need any other information.

Comment 4

[Jason Smith [:jsmith]]

Does this reproduce on a ZTE 1.1 partner build?

Comment 5

[gbennett]

Does not repro on ZTE 1.1 partner build.

Environmental Variables
Device: ZTE 1.1.0.0
Build ID: 20130820074633
Gecko: /rev/
Gaia: a05916a393e9ea4e0b532eec90ce6f076e5454a5
Platform Version: 18.1

Used the same repro steps as prior charging the phone to ~20% and bringing it down to 10% with apps running in the background along with playing youtube. Warning showed correctly at 10%. At what screen was this issue first seen?

Comment 6

[ji.chen5]

Hi  gbennett:

  I have test the bug with the newest version, and it can be reproduced.
  
  I ran videos when baterry remains 30%.When it drop to 9%, there is still no waring for low baterry.  

  We want to see how it processes the event reported from the buttom for the message of low baterry.Could you please tell me which file we could refer to?

Comment 7

[Juan Perez-Bedmar [:juanpbf]]

This is not a blocker for certification in V1.1 but I also think this feature should be implemented in feature versions.

Please consider it for V1.2 --> nominating for koi?

Comment 8

[Preeti Raghunath(:Preeti)]

Juan

Feature landing is not allowed unless it is mandatory. Please confirm if this is actually needed.

Comment 9

[Jason Smith [:jsmith]]

I think you meant to flag Juan in comment 7.

Comment 10

[gbennett]

(In reply to ji.chen5 from comment #6)
> Hi  gbennett:
> 
>   I have test the bug with the newest version, and it can be reproduced.
>   
>   I ran videos when baterry remains 30%.When it drop to 9%, there is still
> no waring for low baterry.  
> 
>   We want to see how it processes the event reported from the buttom for the
> message of low baterry.Could you please tell me which file we could refer to?

I do not know which file you can refer to. Sorry mate.

Comment 11

[Juan Perez-Bedmar [:juanpbf]]

(In reply to Preeti Raghunath(:Preeti) from comment #8)
> Juan
> 
> Feature landing is not allowed unless it is mandatory. Please confirm if
> this is actually needed.

I think we can probably live without this in V1.2. but I will suggest the UX team to consider implementing some kind of pop-up warnings or similar when battery is low for V1.3.

By the time V1.3 will be in the market in commercial devices, we expect to have attracted a lot of new-comers, including some former Android users. This will probably cause that the number of users with a more strict perception of what the "expected behaviour" should be under certain situations (such as this low-battery situation) will increase.

Rafa, what do you think?

Comment 12

[Phoenix]

Resolved per whiteboard

Comment 13

[Juan Perez-Bedmar [:juanpbf]]

Sorry, but I still haven't got feedback from UX team, and I really think this feature should be included in v1.3.

Ivan, could you please help me to reach the proper person/people in UX team to discuss about this feature request? Thanks!

Comment 14

[David Palomino [:dpalomino]]

Hi, 

I think to have this feature would be really useful. Users generally assume this to be present on commercial devices, as it is in the other platforms. 

Could we include this at least for 1.3?

adding Rafa to ni. 

Thanks, 
David

Comment 15

[Ivan Tsay (:ITsay)]

(In reply to Juan Perez-Bedmar [:juanpbf]  -  Good bye summer! from comment #13)
> Sorry, but I still haven't got feedback from UX team, and I really think
> this feature should be included in v1.3.
> 
> Ivan, could you please help me to reach the proper person/people in UX team
> to discuss about this feature request? Thanks!

Hi UX folks,

Would you please take a look this requirement which is suggested by partner to be included in v1.3.

Ivan Tsay

Comment 16

[Stephany Wilkes]

UX was first flagged yesterday (thank you, Ivan). I am flagging Rob and Francis, who are UX for Systems Front-end for 1.3, and Peter so he can follow this for possible backlog inclusion for that team.

Comment 17

[Peter Dolanjski [:pdol]]

(In reply to gbennett from comment #3)
> I ran youtube videos until the battery was reduced to 10% and at that
> percent a prompt/warning appeared for low battery.

I'm slightly confused by the contradictory comments on this bug.  The testing in comment #3 indicate that there is a warning for low battery (unless this refers to the Power Save mode), but other comments say there is no warning.

Admittedly, the implementation of this (if it exists) was before my time, so I'm not sure exactly what is in place today.
  
Do low battery notifications exist?  
If so, are they not working in the vendor build?  
If not, why does comment 3 mention seeing them.

Comment 18

[Juan Perez-Bedmar [:juanpbf]]

(In reply to Peter Dolanjski [:pdol] from comment #17)
> (In reply to gbennett from comment #3)
> > I ran youtube videos until the battery was reduced to 10% and at that
> > percent a prompt/warning appeared for low battery.
> 
> I'm slightly confused by the contradictory comments on this bug.  The
> testing in comment #3 indicate that there is a warning for low battery
> (unless this refers to the Power Save mode), but other comments say there is
> no warning.

I'm also a bit confused here. Comment #3 and Comment #5 makes reference to Youtube, but not to other situations, so even if those comments are correct, this would still be a bug IMHO.
Anyway, I've been trying to see any notification by watching YouTube videos over and over, and once the battery decreases under 10%, the only sign of low battery is the icon itself going red, but no pop-up is shown. 

I'm using a V1.1 commercial build:
QC RIL version:
"ro.build.firmware_revision=01.01.00.019.215"
gaia commit:
4584c40 rm long short
gecko commit:
8ae9e11 tengfei add eng code with 87274

needinfo to [e-mail] for clarification on his comments

Comment 19

[Stephany Wilkes]

To answer Peter's question "Do low battery notifications exist?" in comment #17, yes. On the current build, I see a "Battery almost empty" notification at the top, with a little red battery image, when the battery appears to have about < 5% left.

Comment 20

[gbennett]

(In reply to Juan Perez-Bedmar [:juanpbf] @Madrid from comment #18)
> (In reply to Peter Dolanjski [:pdol] from comment #17)
> > (In reply to gbennett from comment #3)
> > > I ran youtube videos until the battery was reduced to 10% and at that
> > > percent a prompt/warning appeared for low battery.
> > 
> > I'm slightly confused by the contradictory comments on this bug.  The
> > testing in comment #3 indicate that there is a warning for low battery
> > (unless this refers to the Power Save mode), but other comments say there is
> > no warning.
> 
> I'm also a bit confused here. Comment #3 and Comment #5 makes reference to
> Youtube, but not to other situations, so even if those comments are correct,
> this would still be a bug IMHO.
> Anyway, I've been trying to see any notification by watching YouTube videos
> over and over, and once the battery decreases under 10%, the only sign of
> low battery is the icon itself going red, but no pop-up is shown. 
> 
> I'm using a V1.1 commercial build:
> QC RIL version:
> "ro.build.firmware_revision=01.01.00.019.215"
> gaia commit:
> 4584c40 rm long short
> gecko commit:
> 8ae9e11 tengfei add eng code with 87274
> 
> needinfo to [e-mail] for clarification on his comments

Hello Juan, what information would you like specifically?

Comment 21

[Juan Perez-Bedmar [:juanpbf]]

(In reply to gbennett from comment #20)
> 
> Hello Juan, what information would you like specifically?

Hi, my main doubts are:
- Have you seen the prompt/warning in any other situation, or it happens only with YouTube?
- Are the builds you are using based on commercial (Qualcomm's) RIL or Mozilla's RIL?

And if you happen to have a screenshot of the low battery prompt, that would be wonderful.

Thanks in advance

Comment 22

[Peter Dolanjski [:pdol]]

Marco had the following to say:
"Please refer to the link as below where tried to display a overlay toast for battery notification.
https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/battery_manager.js#L121
And the level is 10%.
https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/battery_manager.js#L12

I am not sure whether the issue is related to display between full screen (video playing) and a overlay toast.
This may need the confirm from gaia developers."

Marco, do you know which gaia developer would know this?

Comment 23

[gbennett]

Attachment: BatteryLowMessage.png

(In reply to Juan Perez-Bedmar [:juanpbf] @Madrid from comment #21)
> Hi, my main doubts are:
> - Have you seen the prompt/warning in any other situation, or it happens
> only with YouTube?
> - Are the builds you are using based on commercial (Qualcomm's) RIL or
> Mozilla's RIL?
> 
> And if you happen to have a screenshot of the low battery prompt, that would
> be wonderful.
> 
> Thanks in advance


The battery warning notification appeared while in the settings app using a mozRIL build and on the homescreen as well once the battery dropped below 10%. Heads up reproing this issue without using some sort of streaming service can take a while and if you get stuck at 11%, plug then unplug the device from a computer and the battery % should update quicker. Let me know if you need any other info.

Comment 24

[Marco Chen [:mchen]]

(In reply to Peter Dolanjski [:pdol] from comment #22)
> Marco had the following to say:
> Marco, do you know which gaia developer would know this?

Hi Alive,

Could you take a look to this issue? It's about the low battery prompt didn't be shown during video playing.

Thanks.

Comment 25

[(inactive after 6/18) Alive Kuo [:alive]]

Does this only happens when video is playing? Do you mean built-in video app or youtube.com or vidoe on web page or something else?

Comment 26

[Francis Djabri [:djabber]]

The low battery indicator should be shown in the following circumstances:

1) Battery banner should be shown if the battery level drops beneath a certain threshold (10% for battery almost empty). 

2) Battery banner should be shown if the user wakes up the screen or boots up the device and the battery has dropped below a certain threshold. Battery banner should only be shown once after the threshold is passed - not every time the screen wakes up or the device boots up.

3) Battery banner should be shown if the device charger is disconnected and the battery charge is beneath a certain threshold.

Comment 27

[Jason Smith [:jsmith]]

This isn't a committed feature for 1.3, so this isn't going to block 1.3. Clearing nom.

Comment 28

[BMO Automation]

Firefox OS is not being worked on