Closed
Bug 909043
Opened 11 years ago
Closed 11 years ago
test_reftests_with_caret.html failing on b2g mochitest because of spellcheck test
Categories
(Core :: DOM: Editor, defect)
Tracking
()
RESOLVED
FIXED
mozilla26
People
(Reporter: martijn.martijn, Assigned: martijn.martijn)
References
()
Details
Attachments
(1 file, 1 obsolete file)
|
1.94 KB,
patch
|
Details | Diff | Splinter Review |
This test file is disabled on b2g and Android. I noticed there is 1 failure (out of 31) on b2g mochitest, because there is a test in it that uses spellcheck. Spellcheck is currently disabled on b2g and Android. This immediately reminded me of bug 634626. In this case, the test file shouldn't be disabled completely on Android and b2g, because the other tests are unrelated to spellcheck. It seems to the patch I attached is the best solution and is similar to what you wanted in bug 634626, right?
Attachment #795095 -
Flags: review?(ehsan)
|
||
Comment 1•11 years ago
|
||
Comment on attachment 795095 [details] [diff] [review] test_reftests_with_caret.diff Review of attachment 795095 [details] [diff] [review]: ----------------------------------------------------------------- Yep, thanks!
Attachment #795095 -
Flags: review?(ehsan) → review+
|
Assignee | |
Comment 2•11 years ago
|
||
I'll later remove this test file from b2g.json and android.json (along with some other test files from other bugs)
Attachment #795095 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•11 years ago
|
Keywords: checkin-needed
|
||
Comment 3•11 years ago
|
||
https://hg.mozilla.org/integration/b2g-inbound/rev/551f334744e4
Flags: in-testsuite+
Keywords: checkin-needed
|
|
||
Comment 4•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/551f334744e4
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
You need to log in
before you can comment on or make changes to this bug.
Description
•