9097 - Rshell.ini file: Remove button action to create a desktop shortcut

Status: VERIFIED FIXED

(CCK Graveyard :: CCK-General, defect, P2)

Description

[robinf]

In the Rshell.ini file, the button action that creates a desktop shortcut to a
file or folder in the CD seems useless. This key lets you create a desktop
shortcut when the user clicks a button in a shell dialog. The desktop shortcut
can point to a file or directory on the CD. Here's the syntax:

button1_cmdline=desktop,file or directory name,shortcut name,icon file

When the end-user clicks the shell button, the desktop shortcut gets created on
their desktop. However, clicking the button doesn't also automatically cause the
shortcut to launch. The user must do that separately. This seems like a useless
key, especially since the shortcut can't point to anything that's installed on
the user's hard disk. Brent can't recall a situation when anyone would want to
implement this.

Brent and I suggest that this key gets removed from the rshell.ini file unless
there's a reason to keep it.

Comment 1

[selmer (gone)]

When you double-click on the desktop icon, what happens?

Did you test putting a file name such as c:\foo\bar.exe into one of these button
command lines?

Comment 2

[robinf]

When you double-click the desktop icon, the file/directory associated with the
shortcut launches.

What seems odd about this flag is that clicking a shell button can create the
desktop shortcut to something on the CD, but it doesn't also launch it. So the
button would have to have text that says something like "Click this button to
create a desktop shortcut for blah on the CD", which seems not very useful.
Also, every time the user double-clicks the shortcut and they don't have their
Communicator CD inserted, won't they get an error message?

Comment 3

[robinf]

Re-assigning to Varada.

Comment 4

[robinf]

Elevating to P2 since this affects the doc.

Comment 5

[varada]

I have marked this M11 - but if I have all the other major stuff finished by
next wednesday - I shall get this done by M10

Comment 6

[selmer (gone)]

Bulk move to post-beta1.

Comment 7

[varada]

Deleted button1_cmdline from both the rshell.ini files.

Comment 8

[bmartin]

Reopening this....

The only key and it's comments to be removed was the button1_cmdline=desktop
only.

You removed the button1_cmdline=.exe instead.

The CCK Autorun Shell's rshell.ini should have button1_cmdline=[path to .exe to
launch the CCK XPI Installer from the shell UI button 1], and the CustomCD
Autorun shell's rshell.ini should contain button1_cmdline=[path to .exe that
launches custom build's XPI Installer from the shell UI button 1]  These two
files have yet to be determined.

Comment 9

[varada]

fixed- have checked in the right files

Comment 10

[bmartin]

Marking this Verified Fixed.

Comment 11

[Asa Dotzler [:asa]]

->CCK-General. Other CCK Components going away.