Closed Bug 909824 Opened 11 years ago Closed 10 years ago

Allow Forum Mods to remove images from the Image Gallery

Categories

(support.mozilla.org :: General, defect, P4)

defect

Tracking

(Not tracked)

RESOLVED FIXED
Future

People

(Reporter: kdurant35rules, Unassigned)

References

Details

(Whiteboard: u=contributor c=wiki p=0 s=2014.4)

Lots of bad images recently by random users and admins arent as involved as mods
OS: Linux → All
Hardware: x86 → All
Priority: -- → P4
Target Milestone: --- → Future
Whiteboard: u=contributor c=wiki p= s=2013.backlog
Yes, moderators would love this feature to help us protect the community from nude, violent or other disturbing images. I feel this should have a high priority as the future images could be more devastating than the one we recently ran into.

Admins are not always reachable to resolve these types of issues according to factors like their availability, schedule, vacation/PTO and unavoidable work related events like this week's SUMO workweek in Paris.
As a side note, we run the risk of deleting images that are being used, since there's no way to tell if the image is linked from  a contributor forum post,  a support forum response or a KB article. For example, see Tyler Downer's post here: https://support.mozilla.org/forums/contributors/708051?&page=3#post-52474

Bug 641503  added a "what links here" feature for KB articles and templates but not for images.
Depends on: 613337
Status: UNCONFIRMED → NEW
Ever confirmed: true
> As a side note, we run the risk of deleting images that are being used,
> since there's no way to tell if the image is linked from  a contributor
> forum post,  a support forum response or a KB article. For example, see
> Tyler Downer's post here:
> https://support.mozilla.org/forums/contributors/708051?&page=3#post-52474
> 
> Bug 641503  added a "what links here" feature for KB articles and templates
> but not for images.

Related: Bug 935068 - Add feature: Articles that link to this image
Depends on: 935068
Madalina, Rosana, what is your take on this? Should be rather easy to do in case it makes sense.
Flags: needinfo?(rardila)
Flags: needinfo?(mana)
I would be ok with this if we could solve first Bug 935068 in order to avoid the deletion of valid images.
Flags: needinfo?(mana)
If there's an admin around could you delete this image of a naked penis right away?

https://support.mozilla.org/en-US/gallery/image/14162

It was reported here: 
https://support.mozilla.org/en-US/forums/contributors/708051?page=4#post-55664
(In reply to madalina from comment #6)
> I would be ok with this if we could solve first Bug 935068 in order to avoid
> the deletion of valid images.

How about moving on this ASAP, and not waiting Bug 935068 (so consider removing depends on).

In the interim
Mods may be advised that media images may relate to blogs, webmaker or even light hearted comments and humorous images and should not be removed if in any doubt.
Posters may also wish to annotate using the title or whatever to indicate where the image is to be used.

There is little doubt a penis is likely to be an unsuitable image.

I know it will be a different bug but there are a few places within sumo still lacking report buttons, and some only Admins may edit/delete.
(In reply to John Hesling [:John99] from comment #8)
> (In reply to madalina from comment #6)
> > I would be ok with this if we could solve first Bug 935068 in order to avoid
> > the deletion of valid images.
> 
> How about moving on this ASAP, and not waiting Bug 935068 (so consider
> removing depends on).

I would wait for either bug 935068 or bug 613337 to be fixed first, as a safeguard for images that are being used.

> In the interim
> Mods may be advised that media images may relate to blogs, webmaker or even
> light hearted comments and humorous images and should not be removed if in
> any doubt.

Blogs such as https://blog.mozilla.org/sumo/ shouldn't be using images from the Media Gallery.  Webmaker articles that link to the Media Gallery should be those linked from SUMO, not images used at  https://webmaker.org if that's what you meant.   

As far as I know, only SUMO contributor forum posts, SUMO support forum responses or SUMO KB articles should contain images from the Media Gallery.  (Note that "canned" responses such as https://support.mozilla.org/en-US/kb/forum-response-firefox-crashes can include Media Gallery images that aren't being used in a "regular" KB article.  It's also possible to upload an image to the Media Gallery and then link to it from any support forum post, using the same wiki markup.) 

In addition to advising moderators of rules and guidelines for deleting images, an "image deletion" log would be useful, similar to the "post and thread deletion" log proposed in bug 939938 (deletions by both admin and moderators would be included).  It could be linked from https://support.mozilla.org/en-US/flagged just like the user deactivation log that bug 907660 added ... but that's another bug that would need to be filed, if it can't be made a part of this one.
  
> I know it will be a different bug but there are a few places within sumo
> still lacking report buttons, and some only Admins may edit/delete.

Bug 730767 proposes to add a "Report as Spam" button in the Media Gallery which is being blocked by this bug.
Maybe there is another solution if we want to move faster with this and not wait for the other bugs to be solved. We could allow this but make it a strict guideline that for now we only remove images which are clearly spam such as nudity or violent images. Basically any non-family safe image should fall into this category. Anything else that might look out of place or it is reported but looks safe enough should be ok to stay as we cannot tell if they are being used or not.

I would prefer to solve the other bugs first though, maybe Kadir can give us an estimate on how long will this take?
Flags: needinfo?(a.topal)
Other solutions that don't involve moderators deleting images from the Media Gallery were suggested in this discussion:
https://support.mozilla.org/en-US/forums/contributors/708819 Gallery content should require approval
(In reply to Alice Wyman from comment #9)
> (In reply to John Hesling [:John99] from comment #8)

> .....
> > In the interim
> > Mods may be advised that media images may relate to blogs, webmaker or even
> > light hearted comments and humorous images and should not be removed if in
> > any doubt.
> 
> Blogs such as https://blog.mozilla.org/sumo/ shouldn't be using images from
> the Media Gallery.  Webmaker articles that link to the Media Gallery should
> be those linked from SUMO, not images used at  https://webmaker.org if
> that's what you meant.   
> 
> As far as I know, only SUMO contributor forum posts, SUMO support forum
> responses or SUMO KB articles should contain images from the Media Gallery. 
> ....

Sumo AAQ relating to Firefox Desktop  would mainly be screenshot type images, plus possibly a sprinkling of icons and cartoons.
Sumo AAQ now includes Webmaker AAQ. Someone asking a question relating to Webmaker could conceivably want to add an image and I think that vastly increases the range of image categories that could be included.
(In reply to John Hesling [:John99] from comment #12)
> 
> Sumo AAQ relating to Firefox Desktop  would mainly be screenshot type
> images, plus possibly a sprinkling of icons and cartoons.
> Sumo AAQ now includes Webmaker AAQ. Someone asking a question relating to
> Webmaker could conceivably want to add an image and I think that vastly
> increases the range of image categories that could be included.

If you are talking about images added to questions using the "Add Images - Browse" button under the Post a Reply box, those don't appear in the Media Gallery.  Images added that way already can be deleted by moderators, by clicking on the X in the image thumbnail.   See this question for an example: https://support.mozilla.org/questions/964477#answer-454676
> Images added that way already can be deleted by moderators, by
> clicking on the X in the image thumbnail.   See this question for an
> example: https://support.mozilla.org/questions/964477#answer-454676

Actually, that deletes the image from the forum post.  It might not actually delete it from the 
/media/uploads/images/ directory.
Flags: needinfo?(rardila)
Madalina, we have bug 935068 listed for the next sprint, but I don't know yet about developer availability so I can't say whether we'll get to that in the next sprint. If we don't get to it, we won't be able to do it this year. So, giving moderators the permission with very strict guidelines about using the permission might make sense.
Flags: needinfo?(a.topal)
I see that this is in last year's backlog. Are there any plans or talks to put this into effect?
Flags: needinfo?(mana)
Flags: needinfo?(a.topal)
The "2013" in "2013.backlog" is a misnomer. We only have one backlog and it turns out it's an arduous task to change the name, so we continue using that name.
I'm up for it whenever there's dev time, I will let Kadir comment on the time estimate.
Flags: needinfo?(mana)
(In reply to madalina from comment #18)
> I'm up for it whenever there's dev time, I will let Kadir comment on the
> time estimate.

This is just a permission that needs to be assigned to the right group.
Oops sorry, I was thinking about the other bugs. Ok let's add the permission then :)
Permission was added, closing this.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Madalina, quick question. Do we have to take caution of deleting images to avoid KB deletion or is there a warning before hand?

Clearing needsinfo since bug is closed.
Flags: needinfo?(a.topal)
(In reply to Moses Bermea from comment #22)
> Madalina, quick question. Do we have to take caution of deleting images to
> avoid KB deletion or is there a warning before hand?

That's why this depended on bug 935068. We now show the list of articles an image is listed in: 

https://support.mozilla.org/en-US/gallery/image/10146 (scroll to the bottom)
Unblocking.
No longer depends on: 613337
Couldn't see that option before. Cleared cache and now I can. Nice work Ricky.
Whiteboard: u=contributor c=wiki p= s=2013.backlog → u=contributor c=wiki p=0 s=2014.4
You need to log in before you can comment on or make changes to this bug.