909927 - Minimize the #includes in layout/forms

Status: RESOLVED FIXED

(Core :: Layout, defect)

Comment 1

[(no longer active)]

Attachment: Patch (v1)

Comment 2

[(no longer active)]

https://tbpl.mozilla.org/?tree=Try&rev=2c405b755a46

Comment 3

[Mats Palmgren (inactive)]

Can we make nsButtonFrameRenderer::mFrame be a nsIFrame*?
(and include nsIFrame.h instead of nsFrame.h)

Comment 4

[(no longer active)]

(In reply to comment #3)
> Can we make nsButtonFrameRenderer::mFrame be a nsIFrame*?
> (and include nsIFrame.h instead of nsFrame.h)

Yeah, but I'd rather that happen in another bug.  Is that OK?

This is mostly a bunch of semi-automated removals.

Comment 5

[Mats Palmgren (inactive)]

Sure, no problem.

Comment 6

[Mats Palmgren (inactive)]

Comment on attachment 796253 [details] [diff] [review]
Patch (v1)

r=mats

>layout/forms/nsComboboxControlFrame.h

Technically, I don't think you need "class nsPresState;" here because
it's only used in an arg list for a method that's MOZ_OVERRIDE which
implies the nsPresState type is sufficiently known for that use already.


>layout/forms/nsTextControlFrame.h
> #include "nsIEditor.h"

It would be really nice if we could get rid of that one.  It looks like
it's only needed for the ValueSetter class ... is that even used?


Please file follow-up bugs on s/nsFrame/nsIFrame/ and removing nsIEditor.h,
unless you want to address them as additional patches here.

Comment 7

[Mats Palmgren (inactive)]

It is used from nsTextEditorState.cpp which is why I didn't find it at first:
http://mxr.mozilla.org/mozilla-central/source/content/html/content/src/nsTextEditorState.cpp#1811

Still, I think we can un-inline its methods and get rid of nsIEditor.h

Comment 8

[(no longer active)]

Filed bug 910237 and bug 901242.  Note that the latter will not help with the size of our dependency graph.

Comment 9

[(no longer active)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/19e67876d0cd

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/19e67876d0cd