910210 - Overlay.update() should accept an optional parameter to override internal counter

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Sergi Mansilla [:sergi] (Telenor) [PTO]]

When testing streaming import for massive vcard files, it is convenient to update the progress var in a set interval, to avoid updating it (and touching DOM) hundreds of times per second. It would be good to have an optional parameter to `update` in order to set the progress value, instead of calling the method every time the counter value is incremented by one.

Comment 1

[Sergi Mansilla [:sergi] (Telenor) [PTO]]

Attachment: GitHub PR

Comment 2

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 796616 [details] [diff] [review]
GitHub PR

Hi Sergi, just added a small comment. I know, a bit picky, but just to be sure that we don't shoot our self in the foot ;)

Comment 3

[Joe Cheng [:jcheng] (please needinfo)]

does not seem like a blocker.
if you feel that there is a great user impact on this, please explain and renom.
Thanks

Comment 4

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 796616 [details] [diff] [review]
GitHub PR

Good work, clean and simple.

Comment 5

[Francisco Jordano [:arcturus] [:francisco]]

Regarding the koi? ... is this blocking a koi? Sergi?

I mean, this was part of the work you are doing about changing the import from sdcard to an streaming approach.

Actually, bug 904313 that is nominated to leo?

Do you think it should be leo? then?

Thanks!

Comment 6

[Sergi Mansilla [:sergi] (Telenor) [PTO]]

I don't think it should be leo. Thanks for your review!