910458 - Need to be able to visualize when events are happening

Status: RESOLVED FIXED

(Testing Graveyard :: Eideticker, defect)

Description

[William Lachance (:wlach)]

To validate the work done in bug 888102 (and be able to debug tests written using the information generated there), we need to be able to visualize what's going on. We should be able to do this using a modification of the framediff viewer I added a few weeks ago.

Comment 1

[William Lachance (:wlach)]

Attachment: 0001-Bug-910458-Add-event-visualization-interface-to-fram.patch

Here's my attempt at a visualization interface. Here's what it currently looks like:

http://eideticker.wrla.ch/framediff-view.html?title=Frame%20Difference%20Scrolling%20on%20taskjs.org%20%282013-08-27%29&video=videos/video-1377646940.82.webm&framediff=framediffs/framediff-1377646958.96.json&actionlog=actionlogs/action-log-1377646821.47.json

The red areas represent when actions are happening. You can hover over the graph to get more info on what's going on. In this capture, you can see the gap between the event being triggered and something happening by looking at where the line is flat when the graph is red.

Thanks to :jeads for various suggestions on improving this from my very rough first draft. Other ideas welcome.

Comment 2

[William Lachance (:wlach)]

Attachment: 0001-Bug-910458-Add-event-visualization-interface-to-fram.patch

This patch has some updates based on suggestions from jeads and davehunt:

1. Number the events (so "drag 1", "drag 2" instead of just "drag").
2. Label the events as "Events / Gestures" (making it more clear what they are).
3. Remove the zooming behaviour from the graph (not that useful in this case), if people want to scroll down.

Comment 3

[Geoff Brown [:gbrown]]

Comment on attachment 797399 [details] [diff] [review]
0001-Bug-910458-Add-event-visualization-interface-to-fram.patch

Review of attachment 797399 [details] [diff] [review]:
-----------------------------------------------------------------

::: src/dashboard/js/framediff.js
@@ +56,5 @@
> +          actionColorIndex = actionColorIndex ? 0 : 1;
> +        }
> +      }
> +      // if we're not in action and we have no currentSeries, create one
> +      if (currentSeries === null) {

Did you mean to check for !currentAction here, or is the comment out of date?

Comment 4

[William Lachance (:wlach)]

Pushed: https://github.com/mozilla/eideticker/commit/94143c0938cde191d11e4773abbe74ad95015579

(In reply to Geoff Brown [:gbrown] from comment #3)
> Comment on attachment 797399 [details] [diff] [review]
> 0001-Bug-910458-Add-event-visualization-interface-to-fram.patch
> 
> Review of attachment 797399 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: src/dashboard/js/framediff.js
> @@ +56,5 @@
> > +          actionColorIndex = actionColorIndex ? 0 : 1;
> > +        }
> > +      }
> > +      // if we're not in action and we have no currentSeries, create one
> > +      if (currentSeries === null) {
> 
> Did you mean to check for !currentAction here, or is the comment out of date?

This actually means something slightly different than the comment implies -- we use this type of series to indicate parts of the capture where no event is currently being emitted. I updated the comment to make this more clear:

https://github.com/mozilla/eideticker/commit/94143c0938cde191d11e4773abbe74ad95015579#L2R60

(if it's still unclear what's going on feel free to reopen this bug and I can further amend/document)