910813 - Crash [@ mozilla::widget::AudioSession::StopInternal() ] unplugging USB headset

Status: RESOLVED FIXED

(Core :: Widget: Win32, defect, P1)

Description

[(not currently active) Ted Mielczarek]

I unplugged my USB headset and Firefox crashed:

 	00000000()	
>	moz6E67.tmp!mozilla::widget::AudioSession::StopInternal()  Line 301	C++
 	moz6E67.tmp!mozilla::widget::AudioSession::OnSessionDisconnectedInternal()  Line 428	C++
 	moz6E67.tmp!nsRunnableMethodImpl<void (__thiscall nsRefreshDriver::*)(void),1>::Run()  Line 358	C++
 	moz6E67.tmp!nsThread::ProcessNextEvent(bool mayWait=true, bool * result=0x002af08f)  Line 628	C++
 	moz6E67.tmp!NS_ProcessNextEvent(nsIThread * thread=0x010182e0, bool mayWait=true)  Line 238 + 0x1f bytes	C++
 	moz6E67.tmp!mozilla::ipc::MessagePump::Run(base::MessagePump::Delegate * aDelegate=0x000410e0)  Line 116 + 0xa bytes	C++
 	moz6E67.tmp!MessageLoop::RunHandler()  Line 214	C++
 	moz6E67.tmp!MessageLoop::Run()  Line 188	C++
 	moz6E67.tmp!nsBaseAppShell::Run()  Line 163	C++
 	moz6E67.tmp!nsAppShell::Run()  Line 112 + 0x8 bytes	C++
 	moz6E67.tmp!nsAppStartup::Run()  Line 270	C++
 	moz6E67.tmp!XREMain::XRE_mainRun()  Line 3871 + 0xa bytes	C++
 	moz6E67.tmp!XREMain::XRE_main(int argc=0x00000001, char * * argv=0x01ea1f30, const nsXREAppData * aAppData=0x002af39c)  Line 3939 + 0x6 bytes	C++
 	moz6E67.tmp!XRE_main(int argc=0x00000001, char * * argv=0x01ea1f30, const nsXREAppData * aAppData=0x002af39c, unsigned int aFlags=0x00000000)  Line 4152 + 0xd bytes	C++
 	moz6E85.tmp!do_main(int argc=0x00000001, char * * argv=0x00000000, nsIFile * xreDirectory=0x02018100)  Line 275 + 0x19 bytes	C++
 	moz6E85.tmp!NS_internal_main(int argc=0x00000001, char * * argv=0x01ea1f30)  Line 635 + 0xd bytes	C++
 	moz6E85.tmp!wmain(int argc=0x00000000, wchar_t * * argv=0x01ea1b20)  Line 112	C++
 	moz6E85.tmp!__tmainCRTStartup()  Line 552 + 0x17 bytes	C
 	kernel32.dll!@BaseThreadInitThunk@12()  + 0x12 bytes	
 	ntdll.dll!___RtlUserThreadStart@8()  + 0x27 bytes	
 	ntdll.dll!__RtlUserThreadStart@8()  + 0x1b bytes	

Looks like it had a NULL this in the top frame. Refcounting issue?

Comment 1

[(not currently active) Ted Mielczarek]

Looks like this has been hit a few times in the wild, but not many:
https://crash-stats.mozilla.com/report/list?signature=mozilla%3A%3Awidget%3A%3AAudioSession%3A%3AStopInternal%28%29&product=Firefox&query_type=contains&range_unit=weeks&process_type=any&hang_type=any&date=2013-08-29+18%3A00%3A00&range_value=1

Comment 2

[Mats Palmgren (inactive)]

The volume for this signature is still quite high: ~5000 crashes in the past 28 days.

Jim, Kyle, can either of you take a look please?

Comment 3

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

I'm unlikely to be able to look at this anytime soon.

Comment 4

[Jim Mathies [:jimm]]

I can try to slip this in someplace. If not I'll get it into platform int work.

Comment 5

[Jim Mathies [:jimm]]

nm, filing a separate bug.

Comment 6

[Jim Mathies [:jimm]]

should be fixed by bug 1268233.

Comment 7

[Iulia Cristescu, QA [:JuliaC] (away, please needinfo? [e-mail])]

This is still reproducible on Windows 7 x64 and Mac OS X 10.11.6 platforms with latest Nightly 54.0a1 (2017-02-09) using the following steps:
1. Launch Firefox
2. Go to https://apprtc.appspot.com/, create a room, provide the camera and microphone permissions and join it
3. Join the same room from another station
4. Unplug the USB headset
5. Connect back the USB headset
6. Refresh the page in order to reestablish the call

I've filed a new bug to track this: bug 1338504. Jim, what's your take on this?