Closed Bug 910990 Opened 11 years ago Closed 11 years ago

compile failure in addrs.c due to old header linux/ethtool.h

Categories

(Core :: WebRTC: Networking, defect)

Product:
Core
Component:
WebRTC: Networking
Platform:
All
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla26

People

(Reporter: ewong, Assigned: kk1fff)

References

Details

(Keywords: verifyme, Whiteboard: [seamonkey-2.23-verified])

Attachments

(1 file, 3 obsolete files)

Patch: use old ethtool api if ethtool_cmd.speed_hi doesn't not exist. v-checkin
4.15 KB, patch
Details | Diff | Splinter Review 
Linux32 Trunk now fails to compile due to the following:

/usr/bin/ccache /tools/gcc-4.5/bin/gcc -o local_addr.o -c -I../../../../../dist/system_wrappers -include /builds/slave/c-cen-t-lnx/build/mozilla/config/gcc_hidden.h -DMOZ_GLUE_IN_PROGRAM -DNO_NSPR_10_SUPPORT -DOS_POSIX=1 -DOS_LINUX=1  -D_FILE_OFFSET_BITS=64 -DCHROMIUM_BUILD -DUSE_LIBJPEG_TURBO=1 -DUSE_NSS=1 -DENABLE_ONE_CLICK_SIGNIN -DGTK_DISABLE_SINGLE_INCLUDES=1 -D_ISOC99_SOURCE=1 -DENABLE_REMOTING=1 -DENABLE_WEBRTC=1 -DENABLE_CONFIGURATION_POLICY -DENABLE_INPUT_SPEECH -DENABLE_NOTIFICATIONS -DENABLE_GPU=1 -DUSE_OPENSSL=1 -DENABLE_EGLIMAGE=1 -DUSE_SKIA=1 -DENABLE_TASK_MANAGER=1 -DENABLE_WEB_INTENTS=1 -DENABLE_EXTENSIONS=1 -DENABLE_PLUGIN_INSTALLATION=1 -DENABLE_PROTECTOR_SERVICE=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_THEMES=1 -DENABLE_BACKGROUND=1 -DENABLE_AUTOMATION=1 -DENABLE_PRINTING=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DSANITY_CHECKS -DUSE_TURN -DUSE_ICE -DUSE_RFC_3489_BACKWARDS_COMPATIBLE -DUSE_STUND_0_96 -DUSE_STUN_PEDANTIC -DNR_SOCKET_IS_VOID_PTR -Drestrict= -DR_PLATFORM_INT_TYPES='<stdint.h>' -DR_DEFINED_INT2=int16_t -DR_DEFINED_UINT2=uint16_t -DR_DEFINED_INT4=int32_t -DR_DEFINED_UINT4=uint32_t -DR_DEFINED_INT8=int64_t -DR_DEFINED_UINT8=uint64_t -DLINUX -DHAVE_LIBM=1 -DHAVE_STRDUP=1 -DHAVE_STRLCPY=1 -DHAVE_SYS_TIME_H=1 -DHAVE_VFPRINTF=1 -DNEW_STDIORETSIGTYPE=void -DTIME_WITH_SYS_TIME_H=1 -D__UNUSED__="__attribute__((unused))" -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -I. -I/builds/slave/c-cen-t-lnx/build/mozilla/ipc/chromium/src -I/builds/slave/c-cen-t-lnx/build/mozilla/ipc/glue -I../../../../../ipc/ipdl/_ipdlheaders  -I/builds/slave/c-cen-t-lnx/build/mozilla/media/mtransport/third_party/nICEr/../nrappkit/src/event -I/builds/slave/c-cen-t-lnx/build/mozilla/media/mtransport/third_party/nICEr/../nrappkit/src/log -I/builds/slave/c-cen-t-lnx/build/mozilla/media/mtransport/third_party/nICEr/../nrappkit/src/plugin -I/builds/slave/c-cen-t-lnx/build/mozilla/media/mtransport/third_party/nICEr/../nrappkit/src/registry -I/builds/slave/c-cen-t-lnx/build/mozilla/media/mtransport/third_party/nICEr/../nrappkit/src/share -I/builds/slave/c-cen-t-lnx/build/mozilla/media/mtransport/third_party/nICEr/../nrappkit/src/stats -I/builds/slave/c-cen-t-lnx/build/mozilla/media/mtransport/third_party/nICEr/../nrappkit/src/util -I/builds/slave/c-cen-t-lnx/build/mozilla/media/mtransport/third_party/nICEr/../nrappkit/src/util/libekr -I/builds/slave/c-cen-t-lnx/build/mozilla/media/mtransport/third_party/nICEr/../nrappkit/src/port/generic/include -I/builds/slave/c-cen-t-lnx/build/mozilla/media/mtransport/third_party/nICEr/./src/crypto -I/builds/slave/c-cen-t-lnx/build/mozilla/media/mtransport/third_party/nICEr/./src/ice -I/builds/slave/c-cen-t-lnx/build/mozilla/media/mtransport/third_party/nICEr/./src/net -I/builds/slave/c-cen-t-lnx/build/mozilla/media/mtransport/third_party/nICEr/./src/stun -I/builds/slave/c-cen-t-lnx/build/mozilla/media/mtransport/third_party/nICEr/./src/util -I../../../../../dist/include -I/builds/slave/c-cen-t-lnx/build/mozilla/media/mtransport/third_party/nICEr/../nrappkit/src/port/linux/include  -fPIC  -Wall -Wpointer-arith -Wdeclaration-after-statement -Werror=return-type -Wtype-limits -Wempty-body -Wsign-compare -Wno-unused -Wcast-align -gdwarf-2 -std=gnu99 -fgnu89-inline -fno-strict-aliasing -ffunction-sections -fdata-sections -fno-tree-vrp -pthread -pipe  -DNDEBUG -DTRIMMED -gdwarf-2 -Os -freorder-blocks  -fomit-frame-pointer -Wall -Wno-parentheses -Wno-strict-prototypes -Wmissing-prototypes -m32 -mmmx    -include ../../../../../mozilla-config.h -DMOZILLA_CLIENT -MD -MP -MF .deps/local_addr.o.pp  /builds/slave/c-cen-t-lnx/build/mozilla/media/mtransport/third_party/nICEr/src/net/local_addr.c
nr_interface_prioritizer.o
make[7]: Leaving directory `/builds/slave/c-cen-t-lnx/build/objdir/mozilla/media/mtransport/third_party/nrappkit/nrappkit_nrappkit'
make[6]: Leaving directory `/builds/slave/c-cen-t-lnx/build/objdir/mozilla/media/mtransport/third_party/nrappkit'
/usr/bin/ccache /tools/gcc-4.5/bin/gcc -o nr_interface_prioritizer.o -c -I../../../../../dist/system_wrappers -include /builds/slave/c-cen-t-lnx/build/mozilla/config/gcc_hidden.h -DMOZ_GLUE_IN_PROGRAM -DNO_NSPR_10_SUPPORT -DOS_POSIX=1 -DOS_LINUX=1  -D_FILE_OFFSET_BITS=64 -DCHROMIUM_BUILD -DUSE_LIBJPEG_TURBO=1 -DUSE_NSS=1 -DENABLE_ONE_CLICK_SIGNIN -DGTK_DISABLE_SINGLE_INCLUDES=1 -D_ISOC99_SOURCE=1 -DENABLE_REMOTING=1 -DENABLE_WEBRTC=1 -DENABLE_CONFIGURATION_POLICY -DENABLE_INPUT_SPEECH -DENABLE_NOTIFICATIONS -DENABLE_GPU=1 -DUSE_OPENSSL=1 -DENABLE_EGLIMAGE=1 -DUSE_SKIA=1 -DENABLE_TASK_MANAGER=1 -DENABLE_WEB_INTENTS=1 -DENABLE_EXTENSIONS=1 -DENABLE_PLUGIN_INSTALLATION=1 -DENABLE_PROTECTOR_SERVICE=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_THEMES=1 -DENABLE_BACKGROUND=1 -DENABLE_AUTOMATION=1 -DENABLE_PRINTING=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DSANITY_CHECKS -DUSE_TURN -DUSE_ICE -DUSE_RFC_3489_BACKWARDS_COMPATIBLE -DUSE_STUND_0_96 -DUSE_STUN_PEDANTIC -DNR_SOCKET_IS_VOID_PTR -Drestrict= -DR_PLATFORM_INT_TYPES='<stdint.h>' -DR_DEFINED_INT2=int16_t -DR_DEFINED_UINT2=uint16_t -DR_DEFINED_INT4=int32_t -DR_DEFINED_UINT4=uint32_t -DR_DEFINED_INT8=int64_t -DR_DEFINED_UINT8=uint64_t -DLINUX -DHAVE_LIBM=1 -DHAVE_STRDUP=1 -DHAVE_STRLCPY=1 -DHAVE_SYS_TIME_H=1 -DHAVE_VFPRINTF=1 -DNEW_STDIORETSIGTYPE=void -DTIME_WITH_SYS_TIME_H=1 -D__UNUSED__="__attribute__((unused))" -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -I. -I/builds/slave/c-cen-t-lnx/build/mozilla/ipc/chromium/src -I/builds/slave/c-cen-t-lnx/build/mozilla/ipc/glue -I../../../../../ipc/ipdl/_ipdlheaders  -I/builds/slave/c-cen-t-lnx/build/mozilla/media/mtransport/third_party/nICEr/../nrappkit/src/event -I/builds/slave/c-cen-t-lnx/build/mozilla/media/mtransport/third_party/nICEr/../nrappkit/src/log -I/builds/slave/c-cen-t-lnx/build/mozilla/media/mtransport/third_party/nICEr/../nrappkit/src/plugin -I/builds/slave/c-cen-t-lnx/build/mozilla/media/mtransport/third_party/nICEr/../nrappkit/src/registry -I/builds/slave/c-cen-t-lnx/build/mozilla/media/mtransport/third_party/nICEr/../nrappkit/src/share -I/builds/slave/c-cen-t-lnx/build/mozilla/media/mtransport/third_party/nICEr/../nrappkit/src/stats -I/builds/slave/c-cen-t-lnx/build/mozilla/media/mtransport/third_party/nICEr/../nrappkit/src/util -I/builds/slave/c-cen-t-lnx/build/mozilla/media/mtransport/third_party/nICEr/../nrappkit/src/util/libekr -I/builds/slave/c-cen-t-lnx/build/mozilla/media/mtransport/third_party/nICEr/../nrappkit/src/port/generic/include -I/builds/slave/c-cen-t-lnx/build/mozilla/media/mtransport/third_party/nICEr/./src/crypto -I/builds/slave/c-cen-t-lnx/build/mozilla/media/mtransport/third_party/nICEr/./src/ice -I/builds/slave/c-cen-t-lnx/build/mozilla/media/mtransport/third_party/nICEr/./src/net -I/builds/slave/c-cen-t-lnx/build/mozilla/media/mtransport/third_party/nICEr/./src/stun -I/builds/slave/c-cen-t-lnx/build/mozilla/media/mtransport/third_party/nICEr/./src/util -I../../../../../dist/include -I/builds/slave/c-cen-t-lnx/build/mozilla/media/mtransport/third_party/nICEr/../nrappkit/src/port/linux/include  -fPIC  -Wall -Wpointer-arith -Wdeclaration-after-statement -Werror=return-type -Wtype-limits -Wempty-body -Wsign-compare -Wno-unused -Wcast-align -gdwarf-2 -std=gnu99 -fgnu89-inline -fno-strict-aliasing -ffunction-sections -fdata-sections -fno-tree-vrp -pthread -pipe  -DNDEBUG -DTRIMMED -gdwarf-2 -Os -freorder-blocks  -fomit-frame-pointer -Wall -Wno-parentheses -Wno-strict-prototypes -Wmissing-prototypes -m32 -mmmx    -include ../../../../../mozilla-config.h -DMOZILLA_CLIENT -MD -MP -MF .deps/nr_interface_prioritizer.o.pp  /builds/slave/c-cen-t-lnx/build/mozilla/media/mtransport/third_party/nICEr/src/net/nr_interface_prioritizer.c
addrs.o
/usr/bin/ccache /tools/gcc-4.5/bin/gcc -o addrs.o -c -I../../../../../dist/system_wrappers -include /builds/slave/c-cen-t-lnx/build/mozilla/config/gcc_hidden.h -DMOZ_GLUE_IN_PROGRAM -DNO_NSPR_10_SUPPORT -DOS_POSIX=1 -DOS_LINUX=1  -D_FILE_OFFSET_BITS=64 -DCHROMIUM_BUILD -DUSE_LIBJPEG_TURBO=1 -DUSE_NSS=1 -DENABLE_ONE_CLICK_SIGNIN -DGTK_DISABLE_SINGLE_INCLUDES=1 -D_ISOC99_SOURCE=1 -DENABLE_REMOTING=1 -DENABLE_WEBRTC=1 -DENABLE_CONFIGURATION_POLICY -DENABLE_INPUT_SPEECH -DENABLE_NOTIFICATIONS -DENABLE_GPU=1 -DUSE_OPENSSL=1 -DENABLE_EGLIMAGE=1 -DUSE_SKIA=1 -DENABLE_TASK_MANAGER=1 -DENABLE_WEB_INTENTS=1 -DENABLE_EXTENSIONS=1 -DENABLE_PLUGIN_INSTALLATION=1 -DENABLE_PROTECTOR_SERVICE=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_THEMES=1 -DENABLE_BACKGROUND=1 -DENABLE_AUTOMATION=1 -DENABLE_PRINTING=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DSANITY_CHECKS -DUSE_TURN -DUSE_ICE -DUSE_RFC_3489_BACKWARDS_COMPATIBLE -DUSE_STUND_0_96 -DUSE_STUN_PEDANTIC -DNR_SOCKET_IS_VOID_PTR -Drestrict= -DR_PLATFORM_INT_TYPES='<stdint.h>' -DR_DEFINED_INT2=int16_t -DR_DEFINED_UINT2=uint16_t -DR_DEFINED_INT4=int32_t -DR_DEFINED_UINT4=uint32_t -DR_DEFINED_INT8=int64_t -DR_DEFINED_UINT8=uint64_t -DLINUX -DHAVE_LIBM=1 -DHAVE_STRDUP=1 -DHAVE_STRLCPY=1 -DHAVE_SYS_TIME_H=1 -DHAVE_VFPRINTF=1 -DNEW_STDIORETSIGTYPE=void -DTIME_WITH_SYS_TIME_H=1 -D__UNUSED__="__attribute__((unused))" -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -I. -I/builds/slave/c-cen-t-lnx/build/mozilla/ipc/chromium/src -I/builds/slave/c-cen-t-lnx/build/mozilla/ipc/glue -I../../../../../ipc/ipdl/_ipdlheaders  -I/builds/slave/c-cen-t-lnx/build/mozilla/media/mtransport/third_party/nICEr/../nrappkit/src/event -I/builds/slave/c-cen-t-lnx/build/mozilla/media/mtransport/third_party/nICEr/../nrappkit/src/log -I/builds/slave/c-cen-t-lnx/build/mozilla/media/mtransport/third_party/nICEr/../nrappkit/src/plugin -I/builds/slave/c-cen-t-lnx/build/mozilla/media/mtransport/third_party/nICEr/../nrappkit/src/registry -I/builds/slave/c-cen-t-lnx/build/mozilla/media/mtransport/third_party/nICEr/../nrappkit/src/share -I/builds/slave/c-cen-t-lnx/build/mozilla/media/mtransport/third_party/nICEr/../nrappkit/src/stats -I/builds/slave/c-cen-t-lnx/build/mozilla/media/mtransport/third_party/nICEr/../nrappkit/src/util -I/builds/slave/c-cen-t-lnx/build/mozilla/media/mtransport/third_party/nICEr/../nrappkit/src/util/libekr -I/builds/slave/c-cen-t-lnx/build/mozilla/media/mtransport/third_party/nICEr/../nrappkit/src/port/generic/include -I/builds/slave/c-cen-t-lnx/build/mozilla/media/mtransport/third_party/nICEr/./src/crypto -I/builds/slave/c-cen-t-lnx/build/mozilla/media/mtransport/third_party/nICEr/./src/ice -I/builds/slave/c-cen-t-lnx/build/mozilla/media/mtransport/third_party/nICEr/./src/net -I/builds/slave/c-cen-t-lnx/build/mozilla/media/mtransport/third_party/nICEr/./src/stun -I/builds/slave/c-cen-t-lnx/build/mozilla/media/mtransport/third_party/nICEr/./src/util -I../../../../../dist/include -I/builds/slave/c-cen-t-lnx/build/mozilla/media/mtransport/third_party/nICEr/../nrappkit/src/port/linux/include  -fPIC  -Wall -Wpointer-arith -Wdeclaration-after-statement -Werror=return-type -Wtype-limits -Wempty-body -Wsign-compare -Wno-unused -Wcast-align -gdwarf-2 -std=gnu99 -fgnu89-inline -fno-strict-aliasing -ffunction-sections -fdata-sections -fno-tree-vrp -pthread -pipe  -DNDEBUG -DTRIMMED -gdwarf-2 -Os -freorder-blocks  -fomit-frame-pointer -Wall -Wno-parentheses -Wno-strict-prototypes -Wmissing-prototypes -m32 -mmmx    -include ../../../../../mozilla-config.h -DMOZILLA_CLIENT -MD -MP -MF .deps/addrs.o.pp  /builds/slave/c-cen-t-lnx/build/mozilla/media/mtransport/third_party/nICEr/src/stun/addrs.c
nr_socket_turn.o
/usr/bin/ccache /tools/gcc-4.5/bin/gcc -o nr_socket_turn.o -c -I../../../../../dist/system_wrappers -include /builds/slave/c-cen-t-lnx/build/mozilla/config/gcc_hidden.h -DMOZ_GLUE_IN_PROGRAM -DNO_NSPR_10_SUPPORT -DOS_POSIX=1 -DOS_LINUX=1  -D_FILE_OFFSET_BITS=64 -DCHROMIUM_BUILD -DUSE_LIBJPEG_TURBO=1 -DUSE_NSS=1 -DENABLE_ONE_CLICK_SIGNIN -DGTK_DISABLE_SINGLE_INCLUDES=1 -D_ISOC99_SOURCE=1 -DENABLE_REMOTING=1 -DENABLE_WEBRTC=1 -DENABLE_CONFIGURATION_POLICY -DENABLE_INPUT_SPEECH -DENABLE_NOTIFICATIONS -DENABLE_GPU=1 -DUSE_OPENSSL=1 -DENABLE_EGLIMAGE=1 -DUSE_SKIA=1 -DENABLE_TASK_MANAGER=1 -DENABLE_WEB_INTENTS=1 -DENABLE_EXTENSIONS=1 -DENABLE_PLUGIN_INSTALLATION=1 -DENABLE_PROTECTOR_SERVICE=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_THEMES=1 -DENABLE_BACKGROUND=1 -DENABLE_AUTOMATION=1 -DENABLE_PRINTING=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DSANITY_CHECKS -DUSE_TURN -DUSE_ICE -DUSE_RFC_3489_BACKWARDS_COMPATIBLE -DUSE_STUND_0_96 -DUSE_STUN_PEDANTIC -DNR_SOCKET_IS_VOID_PTR -Drestrict= -DR_PLATFORM_INT_TYPES='<stdint.h>' -DR_DEFINED_INT2=int16_t -DR_DEFINED_UINT2=uint16_t -DR_DEFINED_INT4=int32_t -DR_DEFINED_UINT4=uint32_t -DR_DEFINED_INT8=int64_t -DR_DEFINED_UINT8=uint64_t -DLINUX -DHAVE_LIBM=1 -DHAVE_STRDUP=1 -DHAVE_STRLCPY=1 -DHAVE_SYS_TIME_H=1 -DHAVE_VFPRINTF=1 -DNEW_STDIORETSIGTYPE=void -DTIME_WITH_SYS_TIME_H=1 -D__UNUSED__="__attribute__((unused))" -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -I. -I/builds/slave/c-cen-t-lnx/build/mozilla/ipc/chromium/src -I/builds/slave/c-cen-t-lnx/build/mozilla/ipc/glue -I../../../../../ipc/ipdl/_ipdlheaders  -I/builds/slave/c-cen-t-lnx/build/mozilla/media/mtransport/third_party/nICEr/../nrappkit/src/event -I/builds/slave/c-cen-t-lnx/build/mozilla/media/mtransport/third_party/nICEr/../nrappkit/src/log -I/builds/slave/c-cen-t-lnx/build/mozilla/media/mtransport/third_party/nICEr/../nrappkit/src/plugin -I/builds/slave/c-cen-t-lnx/build/mozilla/media/mtransport/third_party/nICEr/../nrappkit/src/registry -I/builds/slave/c-cen-t-lnx/build/mozilla/media/mtransport/third_party/nICEr/../nrappkit/src/share -I/builds/slave/c-cen-t-lnx/build/mozilla/media/mtransport/third_party/nICEr/../nrappkit/src/stats -I/builds/slave/c-cen-t-lnx/build/mozilla/media/mtransport/third_party/nICEr/../nrappkit/src/util -I/builds/slave/c-cen-t-lnx/build/mozilla/media/mtransport/third_party/nICEr/../nrappkit/src/util/libekr -I/builds/slave/c-cen-t-lnx/build/mozilla/media/mtransport/third_party/nICEr/../nrappkit/src/port/generic/include -I/builds/slave/c-cen-t-lnx/build/mozilla/media/mtransport/third_party/nICEr/./src/crypto -I/builds/slave/c-cen-t-lnx/build/mozilla/media/mtransport/third_party/nICEr/./src/ice -I/builds/slave/c-cen-t-lnx/build/mozilla/media/mtransport/third_party/nICEr/./src/net -I/builds/slave/c-cen-t-lnx/build/mozilla/media/mtransport/third_party/nICEr/./src/stun -I/builds/slave/c-cen-t-lnx/build/mozilla/media/mtransport/third_party/nICEr/./src/util -I../../../../../dist/include -I/builds/slave/c-cen-t-lnx/build/mozilla/media/mtransport/third_party/nICEr/../nrappkit/src/port/linux/include  -fPIC  -Wall -Wpointer-arith -Wdeclaration-after-statement -Werror=return-type -Wtype-limits -Wempty-body -Wsign-compare -Wno-unused -Wcast-align -gdwarf-2 -std=gnu99 -fgnu89-inline -fno-strict-aliasing -ffunction-sections -fdata-sections -fno-tree-vrp -pthread -pipe  -DNDEBUG -DTRIMMED -gdwarf-2 -Os -freorder-blocks  -fomit-frame-pointer -Wall -Wno-parentheses -Wno-strict-prototypes -Wmissing-prototypes -m32 -mmmx    -include ../../../../../mozilla-config.h -DMOZILLA_CLIENT -MD -MP -MF .deps/nr_socket_turn.o.pp  /builds/slave/c-cen-t-lnx/build/mozilla/media/mtransport/third_party/nICEr/src/stun/nr_socket_turn.c
stun_build.o
/usr/bin/ccache /tools/gcc-4.5/bin/gcc -o stun_build.o -c -I../../../../../dist/system_wrappers -include /builds/slave/c-cen-t-lnx/build/mozilla/config/gcc_hidden.h -DMOZ_GLUE_IN_PROGRAM -DNO_NSPR_10_SUPPORT -DOS_POSIX=1 -DOS_LINUX=1  -D_FILE_OFFSET_BITS=64 -DCHROMIUM_BUILD -DUSE_LIBJPEG_TURBO=1 -DUSE_NSS=1 -DENABLE_ONE_CLICK_SIGNIN -DGTK_DISABLE_SINGLE_INCLUDES=1 -D_ISOC99_SOURCE=1 -DENABLE_REMOTING=1 -DENABLE_WEBRTC=1 -DENABLE_CONFIGURATION_POLICY -DENABLE_INPUT_SPEECH -DENABLE_NOTIFICATIONS -DENABLE_GPU=1 -DUSE_OPENSSL=1 -DENABLE_EGLIMAGE=1 -DUSE_SKIA=1 -DENABLE_TASK_MANAGER=1 -DENABLE_WEB_INTENTS=1 -DENABLE_EXTENSIONS=1 -DENABLE_PLUGIN_INSTALLATION=1 -DENABLE_PROTECTOR_SERVICE=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_THEMES=1 -DENABLE_BACKGROUND=1 -DENABLE_AUTOMATION=1 -DENABLE_PRINTING=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DSANITY_CHECKS -DUSE_TURN -DUSE_ICE -DUSE_RFC_3489_BACKWARDS_COMPATIBLE -DUSE_STUND_0_96 -DUSE_STUN_PEDANTIC -DNR_SOCKET_IS_VOID_PTR -Drestrict= -DR_PLATFORM_INT_TYPES='<stdint.h>' -DR_DEFINED_INT2=int16_t -DR_DEFINED_UINT2=uint16_t -DR_DEFINED_INT4=int32_t -DR_DEFINED_UINT4=uint32_t -DR_DEFINED_INT8=int64_t -DR_DEFINED_UINT8=uint64_t -DLINUX -DHAVE_LIBM=1 -DHAVE_STRDUP=1 -DHAVE_STRLCPY=1 -DHAVE_SYS_TIME_H=1 -DHAVE_VFPRINTF=1 -DNEW_STDIORETSIGTYPE=void -DTIME_WITH_SYS_TIME_H=1 -D__UNUSED__="__attribute__((unused))" -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -I. -I/builds/slave/c-cen-t-lnx/build/mozilla/ipc/chromium/src -I/builds/slave/c-cen-t-lnx/build/mozilla/ipc/glue -I../../../../../ipc/ipdl/_ipdlheaders  -I/builds/slave/c-cen-t-lnx/build/mozilla/media/mtransport/third_party/nICEr/../nrappkit/src/event -I/builds/slave/c-cen-t-lnx/build/mozilla/media/mtransport/third_party/nICEr/../nrappkit/src/log -I/builds/slave/c-cen-t-lnx/build/mozilla/media/mtransport/third_party/nICEr/../nrappkit/src/plugin -I/builds/slave/c-cen-t-lnx/build/mozilla/media/mtransport/third_party/nICEr/../nrappkit/src/registry -I/builds/slave/c-cen-t-lnx/build/mozilla/media/mtransport/third_party/nICEr/../nrappkit/src/share -I/builds/slave/c-cen-t-lnx/build/mozilla/media/mtransport/third_party/nICEr/../nrappkit/src/stats -I/builds/slave/c-cen-t-lnx/build/mozilla/media/mtransport/third_party/nICEr/../nrappkit/src/util -I/builds/slave/c-cen-t-lnx/build/mozilla/media/mtransport/third_party/nICEr/../nrappkit/src/util/libekr -I/builds/slave/c-cen-t-lnx/build/mozilla/media/mtransport/third_party/nICEr/../nrappkit/src/port/generic/include -I/builds/slave/c-cen-t-lnx/build/mozilla/media/mtransport/third_party/nICEr/./src/crypto -I/builds/slave/c-cen-t-lnx/build/mozilla/media/mtransport/third_party/nICEr/./src/ice -I/builds/slave/c-cen-t-lnx/build/mozilla/media/mtransport/third_party/nICEr/./src/net -I/builds/slave/c-cen-t-lnx/build/mozilla/media/mtransport/third_party/nICEr/./src/stun -I/builds/slave/c-cen-t-lnx/build/mozilla/media/mtransport/third_party/nICEr/./src/util -I../../../../../dist/include -I/builds/slave/c-cen-t-lnx/build/mozilla/media/mtransport/third_party/nICEr/../nrappkit/src/port/linux/include  -fPIC  -Wall -Wpointer-arith -Wdeclaration-after-statement -Werror=return-type -Wtype-limits -Wempty-body -Wsign-compare -Wno-unused -Wcast-align -gdwarf-2 -std=gnu99 -fgnu89-inline -fno-strict-aliasing -ffunction-sections -fdata-sections -fno-tree-vrp -pthread -pipe  -DNDEBUG -DTRIMMED -gdwarf-2 -Os -freorder-blocks  -fomit-frame-pointer -Wall -Wno-parentheses -Wno-strict-prototypes -Wmissing-prototypes -m32 -mmmx    -include ../../../../../mozilla-config.h -DMOZILLA_CLIENT -MD -MP -MF .deps/stun_build.o.pp  /builds/slave/c-cen-t-lnx/build/mozilla/media/mtransport/third_party/nICEr/src/stun/stun_build.c
stun_client_ctx.o
../../../../../../../mozilla/media/mtransport/third_party/nICEr/src/stun/addrs.c: In function ‘stun_get_siocgifconf_addrs’:
../../../../../../../mozilla/media/mtransport/third_party/nICEr/src/stun/addrs.c:656:57: error: ‘struct ethtool_cmd’ has no member named ‘speed_hi’
make[7]: *** [addrs.o] Error 1
make[7]: *** Waiting for unfinished jobs....
../../../../../../../mozilla/media/mtransport/third_party/nICEr/src/stun/stun_build.c: In function ‘nr_stun_compute_lt_message_integrity_password’:
../../../../../../../mozilla/media/mtransport/third_party/nICEr/src/stun/stun_build.c:328:53: warning: comparison between signed and unsigned integer expressions
make[7]: Leaving directory `/builds/slave/c-cen-t-lnx/build/objdir/mozilla/media/mtransport/third_party/nICEr/nicer_nicer'
make[6]: *** [nicer_nicer_libs] Error 2
make[6]: Leaving directory `/builds/slave/c-cen-t-lnx/build/objdir/mozilla/media/mtransport/third_party/nICEr'
make[5]: *** [nICEr_libs] Error 2
make[5]: Leaving directory `/builds/slave/c-cen-t-lnx/build/objdir/mozilla/media/mtransport/third_party'
make[4]: *** [libs_tier_platform] Error 2
make[4]: Leaving directory `/builds/slave/c-cen-t-lnx/build/objdir/mozilla'
make[3]: *** [tier_platform] Error 2
make[3]: Leaving directory `/builds/slave/c-cen-t-lnx/build/objdir/mozilla'
make[2]: *** [default] Error 2
make[2]: Leaving directory `/builds/slave/c-cen-t-lnx/build/objdir/mozilla'
make[1]: *** [default] Error 2
make[1]: Leaving directory `/builds/slave/c-cen-t-lnx/build/objdir'
make: *** [build] Error 2

I've asked kk1fff on #b2g, and it seems as if the newer header file
linux/ethtool.h does have speed_hi in the struct.

https://github.com/torvalds/linux/blob/master/include/uapi/linux/ethtool.h#L41

Updating only that header could fix it, but it'll probably introduce other
dependencies failing.
Blocks: 825708
Edmund, would you help to try if this patch fixed the failure?
Attachment #797870 - Flags: feedback?(ewong)
(In reply to Patrick Wang [:kk1fff] from comment #1)
> Created attachment 797870 [details] [diff] [review]
> Patch: check if ethtool_cmd.speed_hi available and only use it when it is
> useable.
> 
> Edmund, would you help to try if this patch fixed the failure?

It looks like it's working.  At least it has gotten past the point of failure.
Comment on attachment 797870 [details] [diff] [review]
Patch: check if ethtool_cmd.speed_hi available and only use it when it is useable.

Review of attachment 797870 [details] [diff] [review]:
-----------------------------------------------------------------

Patrick:

Can I have you re-spin this patch so that it uses the presence of a preprocessor define to invoke the old library behavior, rather than requiring a define to use the modern invocation? The nICEr code is a third-party project that we upstream our changes to, and it uses a completely different make system. Basically, we need the behavior to be correct in the absence of any special preprocessor definitions.

Also, for the same reason, please remove MOZ_ from the macro name that appears in addrs.c.

Callek made a suggestion in IRC that may be the easiest path forward here; paraphrased, it was having logic in the build system like:
> if !(MOZ_WEBRTC_HAVE_ETHTOOL_SPEED_HI); DEFINES+="-DNO_HAS_ETHTOOL_SPEED_HI"

And then, in addrs.c:
> #ifdef NO_HAS_ETHTOOL_SPEED_HI

I think to land a patch, we'll need r+ from a build peer for the configure changes, and then an r+ from either me or ekr for the nICEr change.

Thanks!
Attachment #797870 - Flags: review-
Attachment #797870 - Flags: feedback?(ewong) → feedback+
OS: Windows Vista → Linux
Thanks, Adam. Yes, we should use the new API by default.
> +AC_TRY_COMPILE([#include <linux/ethtool.h>],
> +               [struct ethtool_cmd cmd; cmd.speed_hi = 0],
> +               AC_DEFINE(MOZ_WEBRTC_HAVE_ETHTOOL_SPEED_HI),)

I don't know how our build system works, but could we use something like this?:
AC_CHECK_MEMBERS([struct ethtool_cmd.speed_hi],,[AC_DEFINE(...)],)
(In reply to Philip Chee from comment #5)
> > +AC_TRY_COMPILE([#include <linux/ethtool.h>],
> > +               [struct ethtool_cmd cmd; cmd.speed_hi = 0],
> > +               AC_DEFINE(MOZ_WEBRTC_HAVE_ETHTOOL_SPEED_HI),)
> 
> I don't know how our build system works, but could we use something like
> this?:
> AC_CHECK_MEMBERS([struct ethtool_cmd.speed_hi],,[AC_DEFINE(...)],)

I can't run with AC_CHECK_MEMBERS, autoconf says it didn't recognize this macro. It probably because we are using autoconf 2.13.
Address comment 3, build with old ethtool API if we found ethtool_cmd doesn't have speed_hi.

Kyle, could you review the change in build config? Thanks.
Attachment #797870 - Attachment is obsolete: true
Attachment #798201 - Flags: review?(khuey)
Attachment #798201 - Flags: review?(adam)

        Attachment #798201 -
        Attachment is obsolete: true

        Attachment #798201 -
        Flags: review?(khuey)

        Attachment #798201 -
        Flags: review?(adam)

        Attachment #798203 -
        Flags: review?(khuey)

        Attachment #798203 -
        Flags: review?(adam)

        Attachment #798203 -
        Attachment description: 798201: Patch: check if ethtool_cmd.speed_hi available and only use it when it is useable. → Patch: use old ethtool api if ethtool_cmd.speed_hi doesn't not exist.

    
    

    
  
Comment on attachment 798203 [details] [diff] [review]
Patch: use old ethtool api if ethtool_cmd.speed_hi doesn't not exist.

Review of attachment 798203 [details] [diff] [review]:
-----------------------------------------------------------------

The addrs.c change looks good to me. I only glanced over the other two files, but the logic looks sound (with the caveat that I really don't understand .gyp syntax).

        Attachment #798203 -
        Flags: review?(adam) → review+

    
    

    
  
Comment on attachment 798203 [details] [diff] [review]
Patch: use old ethtool api if ethtool_cmd.speed_hi doesn't not exist.

Review of attachment 798203 [details] [diff] [review]:
-----------------------------------------------------------------

r=me

        Attachment #798203 -
        Flags: review?(khuey) → review+

    
    

    
  
Comment on attachment 798203 [details] [diff] [review]
Patch: use old ethtool api if ethtool_cmd.speed_hi doesn't not exist.

EKR, would you help review the nicer.gyp change? Thanks!

        Attachment #798203 -
        Flags: review?(ekr)

    
    

    
  
Comment on attachment 798203 [details] [diff] [review]
Patch: use old ethtool api if ethtool_cmd.speed_hi doesn't not exist.

Review of attachment 798203 [details] [diff] [review]:
-----------------------------------------------------------------

Why are we assuming the feature exists by default? Convention
in this code is to assume it does not.

::: media/mtransport/third_party/nICEr/src/stun/addrs.c
@@ +652,5 @@
>            {
>               /* For wireless network, we won't get ethtool, it's a wired
>                  connection */
>               addrs[n].interface.type = NR_INTERFACE_TYPE_WIRED;
> +#ifdef NO_HAS_ETHTOOL_SPEED_HI

Please change to DONT_HAVE

        Attachment #798203 -
        Flags: review?(ekr) → review+

    
    

    
  
Sorry, please ignore the first comment. I agree with Adam.

    
    

    
  
https://hg.mozilla.org/integration/mozilla-inbound/rev/75bd62bdd4a0
Component: Build Config → General
Product: SeaMonkey → Firefox
Summary: trunk is not compiling due to old header linux/ethtool.h → compile failure in addrs.c due to old header linux/ethtool.h

    
    

    
  
I wonder why this SeaMonkey::Build_Config bug (which prevents SeaMonkey 2.23a1 from building on linux-i686 and linux-x86_64) was moved to Firefox::General for committing the fix.
Whiteboard: [seamonkey-2.23-affected]

    
    

    
  
Good question. I'll move it to Core:
Status: NEW → ASSIGNED
Component: General → WebRTC: Networking
Product: Firefox → Core

    
    

    
  
(In reply to Tony Mechelynck [:tonymec] from comment #16)
> I wonder why this SeaMonkey::Build_Config bug (which prevents SeaMonkey
> 2.23a1 from building on linux-i686 and linux-x86_64) was moved to
> Firefox::General for committing the fix.

I set wrong flag. The fix is in central so I changed the flag, but I should use 'core'. Sorry for confusing.
Assignee: nobody → pwang

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/75bd62bdd4a0
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26

    
    

    
  
Thanks kk1ff and edmorley.

Hourly builds are again being built for SeaMonkey on Linux. The one I'm running now is one, for x86_64:

Mozilla/5.0 (X11; Linux x86_64; rv:26.0) Gecko/20100101 Firefox/26.0 SeaMonkey/2.23a1 ID:20130905090840 c-c:8958f7bad543 m-c:e42374f83509

and the corresponding i686 build has the following seamonkey-2.23a1.en-US.linux-i686.txt:

20130905090840
http://hg.mozilla.org/mozilla-central/rev/e42374f83509
http://hg.mozilla.org/comm-central/rev/8958f7bad543

No nightlies yet, but I suppose there will be one tomorrow.

Therefore I declare this bug VERIFIED from a SeaMonkey point of view. If Core or Firefox testers want to conduct additional tests on their side, please do so; otherwise please set this bug VERIFIED on the basis of the present comment.
Keywords: verifyme
Whiteboard: [seamonkey-2.23-affected] → [seamonkey-2.23-verified]
Hardware: x86 → All

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: