Closed
Bug 910998
Opened 11 years ago
Closed 11 years ago
Commonplace projects don't load the correct locale files
Categories
(Marketplace Graveyard :: General, defect, P2)
Tracking
(Not tracked)
RESOLVED
FIXED
2013-09-17
People
(Reporter: basta, Assigned: spasovski)
References
Details
(Whiteboard: [qa-])
If your locale is set to a non-en-US value, you won't load the correct language pack. https://github.com/mozilla/commbadge/blob/master/src/media/js/l10n.js#L40
Updated•11 years ago
|
Priority: -- → P2
Updated•11 years ago
|
Assignee: nobody → dspasovski
Target Milestone: --- → 2013-09-10
Assignee | ||
Comment 1•11 years ago
|
||
http://cl.ly/image/2s222L1f473r and http://cl.ly/image/372Z1G2N1X3z suggest this works just fine reopen if still an issue
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → WORKSFORME
Comment 2•11 years ago
|
||
They're loading Fireplace's l10n files. There's probably more, but here's approximately what needs doing: 1) Update zamboni's mkt.commonplace's index.html template to include a `data-repo="{{ repo }}"` body attribute. 2) Copy fireplace/Makefile (make sure to change REPO='rocketfuel', etc. at the top) to rocketfuel/Makefile and commbadge/Makefile. 3) Update fireplace/fabfile.py and rocketfuel/fabfile.py to call the Makefile's commands (see fireplace/fabfile.py for measure). 4) Rename or move the l10n files {locale}.js so they're prepended or suffixed with the {repo} name.
Status: RESOLVED → REOPENED
Resolution: WORKSFORME → ---
Comment 3•11 years ago
|
||
https://github.com/mozilla/fireplace/commit/8de62cd https://github.com/mozilla/commonplace/commit/675ee5c
Status: REOPENED → RESOLVED
Closed: 11 years ago → 11 years ago
Resolution: --- → FIXED
Whiteboard: [qa-]
Target Milestone: 2013-09-10 → 2013-09-17
You need to log in
before you can comment on or make changes to this bug.
Description
•