911059 - Move WebAudio's BufferDecoder to its own file so it can be shared with MSE

Status: RESOLVED FIXED

(Core :: Web Audio, defect)

Description

[Matthew Gregan [:kinetik]]

MSE uses something almost identical, so sharing this code avoids duplicating a bunch of boilerplate.

Comment 1

[Matthew Gregan [:kinetik]]

Attachment: v0

Comment 2

[(no longer active)]

Please land this patch on Aurora as well, with a=webaudio.  Thanks!

Comment 3

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 797718 [details] [diff] [review]
v0

Review of attachment 797718 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/media/BufferDecoder.h
@@ +29,5 @@
> +
> +  // This has to be called before decoding begins
> +  void BeginDecoding(nsIThread* aDecodeThread);
> +
> +  virtual ReentrantMonitor& GetReentrantMonitor() MOZ_OVERRIDE;

We can remove "virtual" on these methods, in particular since they have MOZ_OVERRIDE to make it clear they're overrides.

Comment 4

[Matthew Gregan [:kinetik]]

With "virtual" removed:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d5b67c93e1a0

(In reply to :Ehsan Akhgari (needinfo? me!) from comment #2)
> Please land this patch on Aurora as well, with a=webaudio.  Thanks!

Will do!

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

(In reply to Chris Pearce (:cpearce) from comment #3)
> We can remove "virtual" on these methods, in particular since they have
> MOZ_OVERRIDE to make it clear they're overrides.

Nooo, please make them virtual so it's obvious they're virtual!

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/d5b67c93e1a0

Comment 7

[Matthew Gregan [:kinetik]]

Attachment: v0 rebased for aurora

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/0618521e6e13

Comment 9

[u279076]

Is there anything needed from QA here to verify this is fixed?

Comment 10

[Matthew Gregan [:kinetik]]

I don't think so.  There's no logical change, just code moving to a new file.

Comment 11

[u279076]

Thank you Matthew, [qa-].