911291 - [B2G] [Buri] [1.2] [Settings][WiFi] Once connected to a network unable to select it in Settings to view its details or to forget it

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Natalya Kot [:nkot]]

Attachment: logcat

Description:
The user is unable to selected the network they've just attached to from the Settings, blocked to view this network details or to forget the network if needed. 

Repro Steps:
1) Updated Buri to Build ID: 20130830040204
2) Open Settings app
3) Select WiFi
4) Select from a list of Available networks
5) Enter in correct password
6) Once connected and taken back to a WiFi Setting select a network just attached to

Actual:
 Unable to select this network, unable to view its details or to forget this network

Expected:
 The user is able to select this network, view its details, and forget the network if needed

Environmental Variables
Build ID: 20130830040204
Gecko: http://hg.mozilla.org/mozilla-central/rev/c7459bc8e449
Gaia: 407fbfb6a9de68ec4db2f0f3dc6c67463e293f47
Platform Version: 26.0a1
US_20130823

Notes:
Repro frequency: 100%
See attached logcat

Comment 1

[Natalya Kot [:nkot]]

regression range:
Build ID: 20130824040225 - does NOT reproduce
Gecko: http://hg.mozilla.org/mozilla-central/rev/17143a9a0d83
Gaia: 42d88f26420b6c58621d1b68675d512fd10c9fcb
Platform Version: 26.0a1

Build ID: 20130826163255 - Reproduces
Gecko: http://hg.mozilla.org/mozilla-central/rev/14b1e8c2957e
Gaia: 23343e6ea3cc59c3ab0ac9188aaa657bd11da4fd
Platform Version: 26.0a1

*in between builds are broken, unable to start up device after flashing
2013-08-25-04-02-01	
2013-08-26-04-02-01	
2013-08-26-07-47-52

Comment 2

[Tim Guan-tin Chien [:timdream] (please needinfo)]

There is a manage network button right below for users to forget the network.

For other settings (e.g. DHCP, IP address etc) it's considered as a feature request.

Comment 3

[Jason Smith [:jsmith]]

(In reply to Tim Guan-tin Chien [:timdream] (MoCo-TPE) (please ni?) from comment #2)
> There is a manage network button right below for users to forget the network.
> 
> For other settings (e.g. DHCP, IP address etc) it's considered as a feature
> request.

That's incorrect - not a feature request, this is a confirmed regression. We do not tolerate slipping quality in shipping releases in Firefox OS if confirmed regressions are found. They need to be incredibly minor to the point that someone wouldn't notice this regression - this would be noticable, as a user would click something that would be unresponsive. Renoming as such.

Comment 4

[Vincent Chang[:vchang][changyihsin]]

I saw below error message when click the connected AP in settings. [JavaScript Error: "TypeError: simPin is undefined" {file: "app://settings.gaiamobile.org/js/wifi.js" line: 704}]. The simPin might not be assigned correct value.

Comment 5

[Tim Guan-tin Chien [:timdream] (please needinfo)]

(In reply to Jason Smith [:jsmith] from comment #3)
> (In reply to Tim Guan-tin Chien [:timdream] (MoCo-TPE) (please ni?) from
> comment #2)
> > There is a manage network button right below for users to forget the network.
> > 
> > For other settings (e.g. DHCP, IP address etc) it's considered as a feature
> > request.
> 
> That's incorrect - not a feature request, this is a confirmed regression. We
> do not tolerate slipping quality in shipping releases in Firefox OS if
> confirmed regressions are found. They need to be incredibly minor to the
> point that someone wouldn't notice this regression - this would be
> noticable, as a user would click something that would be unresponsive.
> Renoming as such.

Right, I misunderstood this bug.

Comment 6

[Tzu-Lin Huang [:dwi2][:tzhuang]]

Attachment: pull request

Comment 7

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 820844 [details] [review]
pull request

r=me. Thanks for the patch.

Comment 8

[Arthur Chen [:arthurcc][inactive after 6/30]]

master: https://github.com/mozilla-b2g/gaia/commit/af2ee8ddafcdd76fa11175b4604d12f5bc1c5e5b

Comment 9

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted af2ee8ddafcdd76fa11175b4604d12f5bc1c5e5b to:
v1.2: f05f78fc03da83f84d55d27c67a87cb921155c00

Comment 10

[Tony Nguyen]

Verified Fixed on 1.2.

Environmental Variables:
Device: Buri v1.2 comRIL
BuildID: 20131111004004
Gaia: 670b2c8329bca6f142939185be71274166d82bb8
Gecko: 1ac147e4e2f0
Version: 26.0