Closed
Bug 911463
Opened 11 years ago
Closed 11 years ago
nsDOMUIEvent::IsChar() casts nsTextEvent* as nsKeyEvent*
Categories
(Core :: DOM: Events, defect)
Core
DOM: Events
Tracking
()
RESOLVED
FIXED
mozilla26
People
(Reporter: masayuki, Assigned: masayuki)
References
Details
Attachments
(1 file)
|
851 bytes,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
See the patch, it's clearer than my explanation in English :-) Fortunately, this bug is safe. The referring bit is in nsTextEvent instance. I confirmed it with static_assert(): https://tbpl.mozilla.org/?tree=Try&usebuildbot=1&rev=3b1a84e5544b The patch works fine: https://tbpl.mozilla.org/?tree=Try&usebuildbot=1&rev=50ed4aa7bcc8
Attachment #798182 -
Flags: review?(bugs)
|
||
Updated•11 years ago
|
Attachment #798182 -
Flags: review?(bugs) → review+
|
Assignee | |
Comment 1•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/36d12ef42b43
|
||
Comment 2•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/36d12ef42b43
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
You need to log in
before you can comment on or make changes to this bug.
Description
•