911518 - Add YCbCr_420_SP_TILED's color conversion to android::ColorConverter in nexus4

Status: RESOLVED DUPLICATE of bug 911548

(Firefox OS Graveyard :: General, defect)

Description

[Sotaro Ikeda [:sotaro]]

For nexus4's build android JB' AOSP source is used. But the AOSP's default android::ColorConverter do not support color conversion from HAL_PIXEL_FORMAT_YCbCr_420_SP_TILED(0x7FA30C03) to RGB 565. Without the conversion, video frame can not draw to canvas and video app can not generate video's thumbnail. Need to add the color conversion.

Comment 1

[Sotaro Ikeda [:sotaro]]

In qcom's hw, the color conversion is normally done by "libmm-color-convertor.so". The rom include the library. So, the conversion should be possible.

Comment 2

[Sotaro Ikeda [:sotaro]]

codeaurora's source support the conversion. By applying the related part to aosp's srouce, the conversion might be possible in nexus-4.
https://www.codeaurora.org/cgit/external/simcom/platform/frameworks/av/tree/media/libstagefright/colorconversion/ColorConverter.cpp?h=jb-8930-master-dsda

Comment 3

[Sotaro Ikeda [:sotaro]]

Created a rom applying the change in comment #2. But failed to load a function in the following. nuxus4's related function seems different.

> convertFn convertNV12Tile = (convertFn)dlsym(lib, "_ZN7android7convertENS_18ColorConvertParamsES0_Ph");

Comment 4

[Sotaro Ikeda [:sotaro]]

Checked the function's symbol name by using following command.
> nm -D ./libmm-color-convertor.so

Comment 5

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Add a color format support to android::ColorConverter

Confirmed the thumnail generation in video app. To confirm it, I did following.
- Apply attachment 798240 [details] [diff] [review] in Bug 871364.
- Create directory by Bug 910498 Comment 18
- push h.264 video to nexus 4

Comment 6

[Sotaro Ikeda [:sotaro]]

Attachment: patch v2 - Add a color format support to android::ColorConverter

Add Code Aurora Forum's copyright.

Comment 7

[Sotaro Ikeda [:sotaro]]

mwu, does "nexus-4 build" continue to use aosp? not caf?

Comment 8

[Michael Wu [:mwu]]

Nexus 4 is currently on AOSP, but it may change to CAF if we start making builds for it.

Comment 9

[Sotaro Ikeda [:sotaro]]

Merge the patch to Bug 911548.