Closed
Bug 911659
Opened 11 years ago
Closed 11 years ago
build script settings.js would return error when setting GAIA_DEV_PIXELS_PER_PX=1.5
Categories
(Firefox OS Graveyard :: GonkIntegration, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: rudyl, Assigned: yurenju)
Details
Attachments
(1 file)
STR
====
1. in Gaia master branch
2. build Gaia with GAIA_DEV_PIXELS_PER_PX=1.5
> GAIA_DEV_PIXELS_PER_PX=1.5 make
--
[Error log]
run-js-command settings
XMLHttpRequest.send error: [Exception... "Failure" nsresult: "0x80004005 (NS_ERROR_FAILURE)" location: "JS frame :: resource://gre/modules/commonjs/toolkit/loader.js -> file:///Users/rudy/Dev/orig_gaia/build/settings.js :: readFileAsDataURL :: line 17" data: no]
make: *** [profile/settings.json] Error 3
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → yurenju.mozilla
|
|
Assignee | |
Comment 1•11 years ago
|
||
We should fallback to GAIA_DIR/build/wallpaper.jpg if wallpaper@<DEVICE_PIXEL>.jpg not avaiable.
Attachment #798409 -
Flags: review?(timdream)
|
||
Updated•11 years ago
|
Attachment #798409 -
Flags: review?(timdream) → review+
|
|
Assignee | |
Comment 2•11 years ago
|
||
verified on Windows & merged. https://github.com/mozilla-b2g/gaia/commit/33fb7dfe0b5a47c8146e4ea6837cc030369c90d5
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
|
||
Updated•11 years ago
|
Attachment mime type: text/plain → text/x-github-pull-request
You need to log in
before you can comment on or make changes to this bug.
Description
•