911778 - [e.me][bug] Homescreen cloud app icon is wrong size

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Everything.me, defect)

Description

[Ran Ben Aharon [:ranbena] EverythingMe]

Save a cloud app to the Homescreen.
It's size is 60x60 instead of 58x58 which is a grid icons standard size.

Comment 1

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Attachment: 2013-09-11-12-03-59.png

even after pulling the icons up through the search, you will find that icons pixelated.

Comment 2

[Ran Ben Aharon [:ranbena] EverythingMe]

Naoki what you're describing is related to https://bugzilla.mozilla.org/show_bug.cgi?id=915145
This ticket is only about icon size.

Comment 3

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Oh.  Thanks.

Comment 4

[Evyatar 'Tron' Amitay (everything.me)]

Ran - since most of the icons rendering methods have since changes, is this still relevant?

Comment 5

[Ran Ben Aharon [:ranbena] EverythingMe]

Yes, still relevant.

Comment 6

[Evyatar 'Tron' Amitay (everything.me)]

Attachment: Patch - redirect to github PR

Comment 7

[Amir Nissim (:amirn)]

Comment on attachment 8341735 [details] [review]
Patch - redirect to github PR

looks good! (added screenshot, left: before change, right: after)
small comment on Github

Comment 8

[Amir Nissim (:amirn)]

Attachment: left: before change, right: after

Comment 9

[Ran Ben Aharon [:ranbena] EverythingMe]

Notice the icon is still 60x60 when bookmarking from the (e.me) browser chrome.

Comment 10

[Evyatar 'Tron' Amitay (everything.me)]

Fixed comment 9 about bookmarking from inside e.me browser.

Comment 11

[Evyatar 'Tron' Amitay (everything.me)]

landed on master
449b9324ed97c7954aece44c99446658d08eb960

https://github.com/mozilla-b2g/gaia/commit/449b9324ed97c7954aece44c99446658d08eb960

Comment 12

[Ran Ben Aharon [:ranbena] EverythingMe]

Comment on attachment 8341735 [details] [review]
Patch - redirect to github PR

(I approved before landing. For some reason didn't take..)