Closed Bug 912125 Opened 11 years ago Closed 2 months ago

Change signature of Emit1 et al to avoid silly idioms

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Type:
defect

Tracking

()

Status:
RESOLVED WORKSFORME

People

(Reporter: jorendorff, Unassigned)

Details

Most Emit1 call sites only use the result to test for success/failure.

It's error-prone. Out param for the call sites that need it.

While we're on the subject, these should probably be methods of BytecodeEmitter.
Assignee: general → nobody
Severity: normal → S3
Status: NEW → RESOLVED
Closed: 2 months ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.