912489 - Consider including the name of the directory picked by HTMLInputElement.openDirectoryPicker() in File.path

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Jonathan Watt [:jwatt]]

I think we should consider including the name of the directory picked by HTMLInputElement.openDirectoryPicker() in File.path for the files that are picked. Currently the path is relative to this directory, not including the directory's name.

Comment 1

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Oh, yeah, I agree we should include the picked directory's name.

Comment 2

[Jonathan Watt [:jwatt]]

Attachment: patch

Comment 3

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 812527 [details] [diff] [review]
patch

Review of attachment 812527 [details] [diff] [review]:
-----------------------------------------------------------------

r=me either way.

::: content/html/content/src/HTMLInputElement.cpp
@@ +360,5 @@
> +    if (NS_FAILED(aTopDir->GetParent(getter_AddRefs(mTopDirsParent))) {
> +      // This just means that the name of the picked directory won't be
> +      // included in the File.path string.
> +      mTopDirsParent = aTopDir;
> +    }

I would just do

rv = aTopDir->GetParent(...);
NS_ENSURE_SUCCESS(rv, rv);

It seems unlikely that this will fail while the rest of the code would still work.

Up to you though.

Comment 4

[Jonathan Watt [:jwatt]]

Thanks! I left it as-is:

https://hg.mozilla.org/integration/mozilla-inbound/rev/f804fcc84df2

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

(In reply to Jonathan Watt [:jwatt] from comment #4)
> Thanks! I left it as-is:
> 
> https://hg.mozilla.org/integration/mozilla-inbound/rev/f804fcc84df2

And backed out in http://hg.mozilla.org/integration/mozilla-inbound/rev/b13ff613f1cf for build bustage like https://tbpl.mozilla.org/php/getParsedLog.php?id=28640187&tree=Mozilla-Inbound and https://tbpl.mozilla.org/php/getParsedLog.php?id=28639828&tree=Mozilla-Inbound

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/32c6282f3a29